Skip to content

fix(cdk): Move gVisor OCI bundle creation to build time#400

Closed
devin-ai-integration[bot] wants to merge 4 commits intodevin/1741471575-firejail-gvisor-pocfrom
devin/1741546903-fix-gvisor-permissions
Closed

fix(cdk): Move gVisor OCI bundle creation to build time#400
devin-ai-integration[bot] wants to merge 4 commits intodevin/1741471575-firejail-gvisor-pocfrom
devin/1741546903-fix-gvisor-permissions

Conversation

@devin-ai-integration
Copy link
Contributor

This PR targets the following PR:


Description

This PR fixes the permissions issue in the gVisor implementation by moving critical privileged operations (creating directories and files) into the root-access part of the Dockerfile and moving the config itself into a dedicated file rather than generating it at runtime.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The Docker image has been built and tested locally with the 'spec' command to verify that the permissions issue is resolved.

Link to Devin run: https://app.devin.ai/sessions/ee56a86fecf641038ef46b91637465b2
Requested by: Aaron

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - Let's try to improve on the gVisor implementation provided here: <https://github.com/airbytehq/airbyte-python-cdk/pull/399>
Read the devlog in that PR and let's try to fix the permissions issue in gVisor. We'll start by moving critical privileged operations into the root-access part of the Dockerfile (such as creating directories and files) and move the config itself into a dedicated file rather than a cat-to-file in teh bootstrap script as it is now. Stack a PR on top of the existing one, rather than modifying the existing PR.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the bug Something isn't working label Mar 9, 2025
devin-ai-integration bot and others added 3 commits March 9, 2025 19:13
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant