fix(cdk): Move gVisor OCI bundle creation to build time#400
Closed
devin-ai-integration[bot] wants to merge 4 commits intodevin/1741471575-firejail-gvisor-pocfrom
Closed
fix(cdk): Move gVisor OCI bundle creation to build time#400devin-ai-integration[bot] wants to merge 4 commits intodevin/1741471575-firejail-gvisor-pocfrom
devin-ai-integration[bot] wants to merge 4 commits intodevin/1741471575-firejail-gvisor-pocfrom
Conversation
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Contributor
Author
🤖 Devin AI EngineerOriginal prompt from Aaron: I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets the following PR:
Description
This PR fixes the permissions issue in the gVisor implementation by moving critical privileged operations (creating directories and files) into the root-access part of the Dockerfile and moving the config itself into a dedicated file rather than generating it at runtime.
Type of change
How Has This Been Tested?
The Docker image has been built and tested locally with the 'spec' command to verify that the permissions issue is resolved.
Link to Devin run: https://app.devin.ai/sessions/ee56a86fecf641038ef46b91637465b2
Requested by: Aaron