-
Notifications
You must be signed in to change notification settings - Fork 32
chore: add unidecode dep to python CDK #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the unidecode dependency to the Python CDK so that the Google Sheets source can transliterate Unicode into ASCII.
- Introduces
unidecode(^1.3.8) inpyproject.tomlunder core dependencies - Notes usage in the comment for the Google Sheets connector
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)Not applicable for this change, as it only involves a dependency addition. Would you like to also add a test or documentation update to ensure future maintainers know why 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PyTest Results (Full)3 688 tests 3 677 ✅ 18m 0s ⏱️ Results for commit 4823c6a. ♻️ This comment has been updated with latest results. |
|
Probably not needed since the |
|
Psych! Reopening as regression tests showed differences in how emojis are handled by these libraries. Since we create schema properties from sheet cell names in Google Sheets, this means stream properties with emojis in them can be altered, which would be a breaking change. We are going to include the dep in the CDK to unblock the migration, with a comment that it should not be used outside Google Sheets and is intended to be deprecated (probably make for a good L3 issue) |
|
Just noting that the amplitude standard test failure is unrelated: EDIT: Just merged master, error should be gone now as we commented out this connector pending investigation |
aldogonzalez8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED
What
As a prerequisite of migrating Google Sheets to manifest-only, we need to include the unidecode dependency to the CDK.
Unidecode lets us transliterate Unicode text into plain ASCII characters. In other words, it converts characters with accents, diacritics, or non-Latin scripts into a closest possible ASCII representation:
Summary by CodeRabbit
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.