Skip to content

chore: add unidecode dep to python CDK #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristoGrab merged 5 commits into from
Jul 3, 2025
Merged

chore: add unidecode dep to python CDK #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc835ef
chore: add unidecode dep to python CDK
ChristoGrab Jun 30, 2025
0136f1e
Merge branch 'main' into christo/unidecode-dep
ChristoGrab Jul 3, 2025
9cfff17
lockfile
ChristoGrab Jul 3, 2025
f96781f
overlook unused dep
ChristoGrab Jul 3, 2025
4823c6a
Merge branch 'main' into christo/unidecode-dep
ChristoGrab Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 55 additions & 1 deletion poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ xmltodict = ">=0.13,<0.15"
anyascii = "^0.3.2"
whenever = "^0.6.16"
setuptools = "^80.9.0" # Some connectors depend on this as an undeclared transitive dependency (e.g. source-shopify)
unidecode = "^1.3.8" # IMPORTANT: DO NOT USE. Added to support source-google-sheets migration. This dep is deprecated in favour of `anyascii` and is slated for removal.
dateparser = "^1.2.2"

[tool.poetry.group.dev.dependencies]
Expand Down Expand Up @@ -230,6 +231,7 @@ DEP002 = [
"cryptography", # Constrained as transitive dependency due to a bug in newer versions
"google-cloud-secret-manager", # Deptry can't detect that `google.cloud.secretmanager_v1` uses this package
"dateparser", # Used by `source-amazon-seller-partner` for parsing string-formatted dates w/ timezone abbreviations. May add to `AirbyteDateTime`.
"unidecode", # IMPORTANT: DO NOT USE. Added to support source-google-sheets migration. This dep is deprecated in favour of `anyascii` and is slated for removal.

# TODO: Remove these dependencies if not needed:
"avro", # Only imported in `unit_tests` code
Expand Down
Loading