Implement complex CHP template by sstroemer · Pull Request #3 · ait-energy/iesopt-project-template

sstroemer · 2025-06-27T14:25:58Z

This is motivated by / linked to ait-energy/IESopt.jl#101 (which it will fix after being completed).

sstroemer · 2025-06-30T06:42:25Z

Some notes on the first draft:

It's missing a lot of validation checks, I've focused on the core functionality first.
We need to discuss whether this makes sense at all since I got the feeling that this is getting too "large" for being in the YAML itself (compared to an actual Julia file with syntax highlighting, etc.).
I've added a few future parameters as comments, currently only the mandatory base set of parameters is implemented.

Villyes · 2025-07-02T07:59:26Z

templates/CHP.iesopt.template.yaml

@@ -0,0 +1,221 @@
+parameters:
+  mode: ~                           # operation mode: extraction, condensing, backpressure


Suggested change

mode: ~ # operation mode: extraction, condensing, backpressure

mode: ~ # operation mode: extraction (full characteristic field), condensing (power only), backpressure (acc. to power ratio line)

I would like that but maybe too crowded then.

Villyes · 2025-07-02T08:01:09Z

templates/CHP.iesopt.template.yaml

+  power_at_heat_max: ~              # electricity output at maximum heat output
+  power_ratio: 0.55                 # electricity per heat in backpressure operation
+  power_loss_ratio: 0.20            # electricity lost per heat extracted along an isofuel line
+  efficiency_condensing: ~          # electricity per fuel


Suggested change

efficiency_condensing: ~ # electricity per fuel

efficiency_condensing: ~ # electricity per fuel (in condensing mode)

Villyes · 2025-07-02T08:01:57Z

templates/CHP.iesopt.template.yaml

+  power_ratio: 0.55                 # electricity per heat in backpressure operation
+  power_loss_ratio: 0.20            # electricity lost per heat extracted along an isofuel line
+  efficiency_condensing: ~          # electricity per fuel
+  efficiency_backpressure: ~        # electricity+heat per fuel


Is this now the combined efficiency? maybe use that term?

Suggested change

efficiency_backpressure: ~ # electricity+heat per fuel

efficiency_backpressure: ~ # electricity+heat per fuel (combined efficiency)

templates/CHP.iesopt.template.yaml

Villyes · 2025-07-02T08:47:51Z

templates/CHP.iesopt.template.yaml

+        if isnothing(cm)
+            cm = p_max / h_max
+            this.set("power_ratio", cm)
+        end


Being super picky (or will you prevent the input-combination 'cm+h_max+p_at_h_max' in the validate section):

Suggested change

if isnothing(cm)

cm = p_max / h_max

this.set("power_ratio", cm)

end

p_at_h_max= this.get("power_at_heat_max")

if isnothing(p_at_h_max)

p_at_h_max=p_max

end

if isnothing(cm)

cm = p_at_h_max / h_max

this.set("power_ratio", cm)

end

After discussion => we do not want want to allow over-specification, therefore we check for that in the validate, and then do not need to care about any over-specified combinations.

Villyes · 2025-07-02T08:53:18Z

templates/CHP.iesopt.template.yaml

+    node_to: <power_to>
+    lb: 0
+
+# TODO: discuss that these functions get really hard to read/maintain when they grow larger (since in a YAML)


To me, the confusing part is the lack of conversions at the units. Could we reference the lines as a comment or is this stupid?

How much overhead is it to include individual units (e.g., one additional one for backpressure because the modeling via combined efficiency is different anyhow?) Then we could also have the backpressure calculation with the extraction-calculation-method.

How much overhead is it to include individual units (e.g., one additional one for backpressure because the modeling via combined efficiency is different anyhow?) Then we could also have the backpressure calculation with the extraction-calculation-method.

We'll do that sounds helpful!

templates/CHP.iesopt.template.yaml

Villyes · 2025-07-02T09:21:15Z

templates/CHP.iesopt.template.yaml

+        cm = this.get("power_ratio")
+        cv = this.get("power_loss_ratio")
+
+        if isnothing(p_max)


Confusing to me. Isn´t p_max one of the required inputs. Why wouldn´t you have this one.

Villyes · 2025-07-02T09:24:25Z

templates/CHP.iesopt.template.yaml

+            h_max = isnothing(p_at_h_max) ? (p_max / (cm + cv)) : (p_at_h_max / cm)
+            this.set("heat_max", h_max)
+        end
+


Suggested change

if isnothing(p_at_h_max)

p_at_h_max=p_max

end

Villyes · 2025-07-02T10:39:53Z

templates/CHP.iesopt.template.yaml

+        if !isnothing(eta_cd) && isnothing(eta_bp)
+            eta_p = eta_cd
+        elseif isnothing(eta_cd) && !isnothing(eta_bp)
+            eta_p = eta_bp / (1.0 + cm)


Please check. I arrive at:

Suggested change

eta_p = eta_bp / (1.0 + cm)

eta_p = eta_bp * cm / (1.0 + cm)

Villyes

Only one major comment in line 180.

Did not review validate-section. Maybe we need to talk about what combination of inputs are ok.

Otherwise: I like it. Took me however a significant amount of time to understand and that although I already know the topic. Still think it´s worth it.

add initial placeholder for refactored CHP template

3ef4be1

sstroemer self-assigned this Jun 27, 2025

sstroemer added the enhancement New feature or request label Jun 27, 2025

sstroemer mentioned this pull request Jun 27, 2025

CHP template wishlist ait-energy/IESopt.jl#101

Open

sstroemer added 6 commits June 27, 2025 18:52

refactor parameters and add some basic validation checks

985ba53

rough structure of internal components

83b8e5d

implement first full set of (basic) functionality for all modes

380a865

improve validation checks

80b1af7

update docstrings of parameters

1718243

add a note on complexity of working with functions in the YAML

abfb720

sstroemer requested a review from Villyes June 30, 2025 06:39

Villyes reviewed Jul 2, 2025

View reviewed changes

templates/CHP.iesopt.template.yaml Show resolved Hide resolved

Villyes reviewed Jul 2, 2025

View reviewed changes

templates/CHP.iesopt.template.yaml Show resolved Hide resolved

Villyes reviewed Jul 2, 2025

View reviewed changes

		@@ -0,0 +1,221 @@
		parameters:
		mode: ~ # operation mode: extraction, condensing, backpressure

	mode: ~ # operation mode: extraction, condensing, backpressure
	mode: ~ # operation mode: extraction (full characteristic field), condensing (power only), backpressure (acc. to power ratio line)

	efficiency_condensing: ~ # electricity per fuel
	efficiency_condensing: ~ # electricity per fuel (in condensing mode)

	efficiency_backpressure: ~ # electricity+heat per fuel
	efficiency_backpressure: ~ # electricity+heat per fuel (combined efficiency)

+        if isnothing(p_at_h_max)
+            p_at_h_max=p_max
+        end

Conversation

sstroemer commented Jun 27, 2025

Uh oh!

sstroemer commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Villyes Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Villyes Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Villyes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Villyes Jul 2, 2025 •

edited

Loading

Villyes Jul 2, 2025 •

edited

Loading