[Obsolete] IWithBoundedStash > IWithStash

[eaba]

Changes

"Use IWithStash with a configured BoundedDeque-based mailbox instead."

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

• This change follows the Akka.NET API Compatibility Guidelines.
• This change follows the Akka.NET Wire Compatibility Guidelines.
• I have reviewed my own pull request.
• Design discussion issue #
• Changes in public API reviewed, if any.
• I have added website documentation for this feature.

Latest dev Benchmarks

Include data from the relevant benchmark prior to this change here.

This PR's Benchmarks

Include data from after this change here.

[Aaronontheweb]

Didn't we just have a PR where we tried to do this prior to v1.5? cc @Arkatufus @ismaelhamed

[ismaelhamed]

IWithStash must resolve to an unbounded deque mailbox by default, which is how it is configured in the hocon (L466)

@Aaronontheweb I don't think this code has ever worked as intended, because BoundedStashImpl and UnboundedStashImpl are the exact same implementation.

Unless I'm missing something we could simply it:

public static class StashFactory
{
    private class StashSupport : AbstractStash
    {
        public StashSupport(IActorContext context)
            : base(context)
        { }
    }

    public static IStash CreateStash(this IActorContext context) => new StashSupport(context);
}

[eaba]

@ismaelhamed

https://github.com/eaba/akka.net/blob/d8b6a908f5630d90ae1f8920628d039c37e51e99/src/core/Akka.Tests/Actor/StashMailboxSpec.cs#L19-L53

[eaba]

[ismaelhamed]

IWithStash resolves to an unbounded deque by default, which is why it is falling. It is not a replacement for IWithBoundedStash. See its documentation.

[Aaronontheweb]

@eaba closing this PR - just suppress the warnings where they show up. No one users this feature much anyway.

[Aaronontheweb]

Actually, per @Arkatufus suggestion - remove the Obsolete attribute on IWithBoundedStash. It's completely misleading.

[ismaelhamed]

Actually, per @Arkatufus suggestion - remove the Obsolete attribute on IWithBoundedStash. It's completely misleading.

Actually, it's telling how to properly create a working bounded stash. If you only rely on the IWithBoundedStash attribute you'll end up with a BoundedDeque with a stash capacity of -1, since you cannot set the stash capacity via the interface (needs to be done via configuration).

[Aaronontheweb]

Actually, per @Arkatufus suggestion - remove the Obsolete attribute on IWithBoundedStash. It's completely misleading.

Actually, it's telling how to properly create a working bounded stash. If you only rely on the IWithBoundedStash attribute you'll end up with a BoundedDeque with a stash capacity of -1, since you cannot set the stash capacity via the interface (needs to be done via configuration).

I'm out of my depth here - would you care to send a PR?

[ismaelhamed]

Sure thing, I'll see if I can find some time tomorrow.

[Aaronontheweb]

Superseded via #6519