Skip to content

Remove deprecated IWithBoundedStash#6519

Open
ismaelhamed wants to merge 1 commit intoakkadotnet:devfrom
ismaelhamed:remove-iwithboundedstash
Open

Remove deprecated IWithBoundedStash#6519
ismaelhamed wants to merge 1 commit intoakkadotnet:devfrom
ismaelhamed:remove-iwithboundedstash

Conversation

@ismaelhamed
Copy link
Member

Supersedes #6511

Changes

  • Removed deprecated IWithBoundedStashinterface.
  • Refactored StashFactory and removed unnecessary AbstractStash implementations.
  • Brought ActorWithStashSpec up-to-date with the JVM.

Checklist

@ismaelhamed
Copy link
Member Author

ismaelhamed commented Mar 15, 2023

Creating an actor with bounded stash:

stash-capacity-mailbox {
  mailbox-type = "Akka.Dispatch.BoundedDequeBasedMailbox"
  stash-capacity = 50
}

...

public class StashCapacityActor : ReceiveActor, IWithStash
{
    public IStash Stash { get; set; }

    public static Props Props() => 
        Akka.Actor.Props.Create<StashCapacityActor>().WithMailbox("stash-capacity-mailbox");
}

or

public class StashCapacityActor : UntypedActorWithStash
{
    public static Props Props() => 
        Akka.Actor.Props.Create<StashCapacityActor>().WithMailbox("stash-capacity-mailbox");
}

@ismaelhamed ismaelhamed force-pushed the remove-iwithboundedstash branch from b1483fb to ff518d3 Compare March 15, 2023 10:58
@ismaelhamed ismaelhamed force-pushed the remove-iwithboundedstash branch from ff518d3 to 9b1736d Compare March 16, 2023 07:06
@ismaelhamed ismaelhamed marked this pull request as ready for review March 16, 2023 09:06
@Aaronontheweb Aaronontheweb added this to the 1.5.2 milestone Mar 16, 2023
@Aaronontheweb Aaronontheweb self-requested a review March 16, 2023 14:51
@Aaronontheweb
Copy link
Member

thanks @ismaelhamed - we'll take a look at this.

@ismaelhamed ismaelhamed force-pushed the remove-iwithboundedstash branch from 9b1736d to 340ce15 Compare March 18, 2023 08:03
@ismaelhamed ismaelhamed force-pushed the remove-iwithboundedstash branch from 340ce15 to e311866 Compare March 22, 2023 06:42
@Aaronontheweb
Copy link
Member

I'm going to need to see if this breaks stashing support with Phobos or not - then I can review the rest of the PRs on its merits. I think it should be fine, but I need to make sure.

@Aaronontheweb
Copy link
Member

Yeah this causes some compilation errors with Phobos - so I think what I'm going to do here is slate this for v1.6 (starting work on this in the fall.) I don't want to rock the boat with any additional breaking changes to v1.5 right now.

@Aaronontheweb Aaronontheweb modified the milestones: 1.5.2, 1.6.0 Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants