Remove deprecated IWithBoundedStash#6519
Open
ismaelhamed wants to merge 1 commit intoakkadotnet:devfrom
Open
Conversation
Member
Author
|
Creating an actor with bounded stash: |
b1483fb to
ff518d3
Compare
6 tasks
ff518d3 to
9b1736d
Compare
Member
|
thanks @ismaelhamed - we'll take a look at this. |
9b1736d to
340ce15
Compare
340ce15 to
e311866
Compare
Member
|
I'm going to need to see if this breaks stashing support with Phobos or not - then I can review the rest of the PRs on its merits. I think it should be fine, but I need to make sure. |
Member
|
Yeah this causes some compilation errors with Phobos - so I think what I'm going to do here is slate this for v1.6 (starting work on this in the fall.) I don't want to rock the boat with any additional breaking changes to v1.5 right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #6511
Changes
IWithBoundedStashinterface.StashFactoryand removed unnecessaryAbstractStashimplementations.ActorWithStashSpecup-to-date with the JVM.Checklist