Skip to content

Remove deprecated IWithBoundedStash #6519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ismaelhamed wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove deprecated IWithBoundedStash #6519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Core.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,8 +1166,6 @@ namespace Akka.Actor
void Become(Akka.Actor.UntypedReceive receive);
void BecomeStacked(Akka.Actor.UntypedReceive receive);
}
[System.ObsoleteAttribute("Use `IWithStash` with a configured BoundedDeque-based mailbox instead.")]
public interface IWithBoundedStash : Akka.Actor.IActorStash, Akka.Actor.IWithUnrestrictedStash, Akka.Dispatch.IRequiresMessageQueue<Akka.Dispatch.IBoundedDequeBasedMessageQueueSemantics> { }
public interface IWithStash : Akka.Actor.IActorStash, Akka.Actor.IWithUnrestrictedStash, Akka.Dispatch.IRequiresMessageQueue<Akka.Dispatch.IDequeBasedMessageQueueSemantics> { }
public interface IWithTimers
{
Expand Down Expand Up @@ -1724,10 +1722,7 @@ namespace Akka.Actor
}
public class static StashFactory
{
public static Akka.Actor.IStash CreateStash<T>(this Akka.Actor.IActorContext context)
where T : Akka.Actor.ActorBase { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context, Akka.Actor.IActorStash actorInstance) { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context, System.Type actorType) { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context) { }
}
public class StashOverflowException : Akka.Actor.AkkaException
{
Expand Down Expand Up @@ -1983,10 +1978,6 @@ namespace Akka.Actor.Internal
public override bool TryGetExtension<T>(out T extension)
where T : class, Akka.Actor.IExtension { }
}
public class BoundedStashImpl : Akka.Actor.Internal.AbstractStash
{
public BoundedStashImpl(Akka.Actor.IActorContext context) { }
}
public class ChildNameReserved : Akka.Actor.Internal.IChildStats
{
public static Akka.Actor.Internal.ChildNameReserved Instance { get; }
Expand Down Expand Up @@ -2129,10 +2120,6 @@ namespace Akka.Actor.Internal
public override string ToString() { }
public override Akka.Actor.Internal.IChildrenContainer Unreserve(string name) { }
}
public class UnboundedStashImpl : Akka.Actor.Internal.AbstractStash
{
public UnboundedStashImpl(Akka.Actor.IActorContext context) { }
}
}
namespace Akka.Actor.Setup
{
Expand Down
15 changes: 1 addition & 14 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,8 +1168,6 @@ namespace Akka.Actor
void Become(Akka.Actor.UntypedReceive receive);
void BecomeStacked(Akka.Actor.UntypedReceive receive);
}
[System.ObsoleteAttribute("Use `IWithStash` with a configured BoundedDeque-based mailbox instead.")]
public interface IWithBoundedStash : Akka.Actor.IActorStash, Akka.Actor.IWithUnrestrictedStash, Akka.Dispatch.IRequiresMessageQueue<Akka.Dispatch.IBoundedDequeBasedMessageQueueSemantics> { }
public interface IWithStash : Akka.Actor.IActorStash, Akka.Actor.IWithUnrestrictedStash, Akka.Dispatch.IRequiresMessageQueue<Akka.Dispatch.IDequeBasedMessageQueueSemantics> { }
public interface IWithTimers
{
Expand Down Expand Up @@ -1726,10 +1724,7 @@ namespace Akka.Actor
}
public class static StashFactory
{
public static Akka.Actor.IStash CreateStash<T>(this Akka.Actor.IActorContext context)
where T : Akka.Actor.ActorBase { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context, Akka.Actor.IActorStash actorInstance) { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context, System.Type actorType) { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context) { }
}
public class StashOverflowException : Akka.Actor.AkkaException
{
Expand Down Expand Up @@ -1985,10 +1980,6 @@ namespace Akka.Actor.Internal
public override bool TryGetExtension<T>(out T extension)
where T : class, Akka.Actor.IExtension { }
}
public class BoundedStashImpl : Akka.Actor.Internal.AbstractStash
{
public BoundedStashImpl(Akka.Actor.IActorContext context) { }
}
public class ChildNameReserved : Akka.Actor.Internal.IChildStats
{
public static Akka.Actor.Internal.ChildNameReserved Instance { get; }
Expand Down Expand Up @@ -2131,10 +2122,6 @@ namespace Akka.Actor.Internal
public override string ToString() { }
public override Akka.Actor.Internal.IChildrenContainer Unreserve(string name) { }
}
public class UnboundedStashImpl : Akka.Actor.Internal.AbstractStash
{
public UnboundedStashImpl(Akka.Actor.IActorContext context) { }
}
}
namespace Akka.Actor.Setup
{
Expand Down
15 changes: 1 addition & 14 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,8 +1166,6 @@ namespace Akka.Actor
void Become(Akka.Actor.UntypedReceive receive);
void BecomeStacked(Akka.Actor.UntypedReceive receive);
}
[System.ObsoleteAttribute("Use `IWithStash` with a configured BoundedDeque-based mailbox instead.")]
public interface IWithBoundedStash : Akka.Actor.IActorStash, Akka.Actor.IWithUnrestrictedStash, Akka.Dispatch.IRequiresMessageQueue<Akka.Dispatch.IBoundedDequeBasedMessageQueueSemantics> { }
public interface IWithStash : Akka.Actor.IActorStash, Akka.Actor.IWithUnrestrictedStash, Akka.Dispatch.IRequiresMessageQueue<Akka.Dispatch.IDequeBasedMessageQueueSemantics> { }
public interface IWithTimers
{
Expand Down Expand Up @@ -1724,10 +1722,7 @@ namespace Akka.Actor
}
public class static StashFactory
{
public static Akka.Actor.IStash CreateStash<T>(this Akka.Actor.IActorContext context)
where T : Akka.Actor.ActorBase { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context, Akka.Actor.IActorStash actorInstance) { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context, System.Type actorType) { }
public static Akka.Actor.IStash CreateStash(this Akka.Actor.IActorContext context) { }
}
public class StashOverflowException : Akka.Actor.AkkaException
{
Expand Down Expand Up @@ -1983,10 +1978,6 @@ namespace Akka.Actor.Internal
public override bool TryGetExtension<T>(out T extension)
where T : class, Akka.Actor.IExtension { }
}
public class BoundedStashImpl : Akka.Actor.Internal.AbstractStash
{
public BoundedStashImpl(Akka.Actor.IActorContext context) { }
}
public class ChildNameReserved : Akka.Actor.Internal.IChildStats
{
public static Akka.Actor.Internal.ChildNameReserved Instance { get; }
Expand Down Expand Up @@ -2129,10 +2120,6 @@ namespace Akka.Actor.Internal
public override string ToString() { }
public override Akka.Actor.Internal.IChildrenContainer Unreserve(string name) { }
}
public class UnboundedStashImpl : Akka.Actor.Internal.AbstractStash
{
public UnboundedStashImpl(Akka.Actor.IActorContext context) { }
}
}
namespace Akka.Actor.Setup
{
Expand Down
7 changes: 1 addition & 6 deletions src/core/Akka.Persistence/Eventsourced.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ protected Eventsourced()
_instanceId = InstanceCounter.GetAndIncrement();
_writerGuid = Guid.NewGuid().ToString();
_currentState = null;
_internalStash = CreateStash();
_internalStash = Context.CreateStash();
Log = Context.GetLogger();
}

Expand Down Expand Up @@ -609,11 +609,6 @@ private void FlushJournalBatch()
}
}

private IStash CreateStash()
{
return Context.CreateStash(GetType());
}

private void StashInternally(object currentMessage)
{
try
Expand Down
4 changes: 2 additions & 2 deletions src/core/Akka.Tests/Actor/Stash/ActorWithBoundedStashSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

namespace Akka.Tests.Actor.Stash
{
public class StashingActor : UntypedActor, IWithBoundedStash
public class StashingActor : UntypedActor, IWithStash
{
public IStash Stash { get; set; }

Expand All @@ -39,7 +39,7 @@ protected override void OnReceive(object message)
private void AfterWorldBehavior(object message) => Stash.Stash();
}

public class StashingActorWithOverflow : UntypedActor, IWithBoundedStash
public class StashingActorWithOverflow : UntypedActor, IWithStash
{
private int numStashed = 0;

Expand Down
Loading