Skip to content

chore(deps): bump rules_java to 7.3.1 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertocavalcante merged 1 commit into from
Jun 9, 2025
Merged

chore(deps): bump rules_java to 7.3.1 #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WORKSPACE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_jar")

http_archive(
name = "rules_java",
sha256 = "16bc94b1a3c64f2c36ceecddc9e09a643e80937076b97e934b96a8f715ed1eaa",
sha256 = "4018e97c93f97680f1650ffd2a7530245b864ac543fd24fae8c02ba447cb2864",
urls = [
"https://github.com/bazelbuild/rules_java/releases/download/6.5.2/rules_java-6.5.2.tar.gz",
"https://github.com/bazelbuild/rules_java/releases/download/7.3.1/rules_java-7.3.1.tar.gz",
Comment on lines +7 to +9
Copy link

@gemini-code-assist gemini-code-assist bot Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating rules_java from 6.5.2 to 7.3.1 is a notable version jump. The 7.x series of rules_java introduces some important changes, including:

  • The default Java toolchain is now based on JDK 17 (previously JDK 11).
  • Bazel 6.0.0 or newer is required.

Could you confirm if:

  1. The project has been tested with these new defaults, particularly the implications of using JDK 17 by default?
  2. The Bazel version currently used by the project meets the new minimum requirement of 6.0.0+?

Understanding these aspects is crucial for ensuring a smooth upgrade. It might also be beneficial to explicitly state any necessary configuration changes or testing performed in the PR description.

],
)

Expand Down
2 changes: 1 addition & 1 deletion antlr/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ PACKAGES = {

def _fail_with_attr(message, attr_name):
"""Helper function for consistent error handling with attribute context."""
fail(message, attr = attr_name) # type: ignore
fail(message, attr = attr_name) # type: ignore

def rules_antlr_dependencies(*versions_and_languages):
"""Loads the dependencies for the specified ANTLR releases.
Expand Down