-
Notifications
You must be signed in to change notification settings - Fork 2
chore(deps): bump rules_java to 7.3.1 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update modifies the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: https://app.greptile.com/review/github.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @albertocavalcante, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello, this is gemini-code-assist providing a summary of this pull request. The primary goal of this PR is to update the rules_java dependency used in the Bazel build system. Specifically, it bumps the version from 6.5.2 to 7.3.1 in the WORKSPACE.bazel file, along with the corresponding SHA256 hash. Additionally, there is a minor, non-functional change in antlr/repositories.bzl involving whitespace in a comment.
Highlights
- Dependency Update: Updates the
rules_javaBazel dependency from version 6.5.2 to 7.3.1 in theWORKSPACE.bazelfile. - SHA256 Hash Update: Updates the SHA256 hash for the new
rules_javaversion inWORKSPACE.bazel. - Minor Code Style Change: Adjusts whitespace in a comment in the
antlr/repositories.bzlfile.
Changelog
- WORKSPACE.bazel
- Updated
rules_javadependency version from 6.5.2 to 7.3.1. - Updated SHA256 hash for the new
rules_javaversion.
- Updated
- antlr/repositories.bzl
- Minor whitespace adjustment in a comment on line 166.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR updates rules_java to version 7.3.1 and includes a minor stylistic fix in antlr/repositories.bzl. The dependency update from 6.5.2 to 7.3.1 is a significant one.
To improve clarity for reviewers and future maintainers, could you please consider adding a brief note to the PR description? Linking to the rules_java 7.x release notes (e.g., 7.0.0 for major changes and 7.3.1 for this specific version) would be very helpful to highlight key changes, such as the default JDK version moving to 17 and the Bazel 6+ requirement.
Summary of Findings
rules_javaUpgrade Implications: The update ofrules_javato 7.3.1 brings significant changes, such as the default Java toolchain now being JDK 17 (previously JDK 11) and a requirement for Bazel 6.0.0+. Confirmation of testing and compatibility with these changes is recommended to ensure the project continues to build and function as expected.- Stylistic Improvement (Low Severity): A stylistic improvement was made in
antlr/repositories.bzl(line 166) by adding an extra space before an inline comment (# type: ignore). This aligns with common style practices like PEP 8, which recommends two spaces before inline comments. This is a positive change for code readability. (Not commented on directly due to review severity settings focusing on medium+ issues).
Merge Readiness
This pull request updates a key dependency, rules_java, to a significantly newer version. While the code changes themselves are minimal, the implications of this upgrade (such as a new default JDK version and Bazel version requirements) are important to consider.
I recommend that the author confirm that the project has been thoroughly tested with rules_java 7.3.1 and that it is compatible with the new defaults and requirements. Adding details about this verification and linking to the rules_java release notes in the PR description would greatly benefit the review process and future maintainability.
As a reviewer, I am not authorized to approve pull requests. Given the medium severity concern raised regarding the implications of the dependency upgrade, I suggest these points be addressed or confirmed before this PR is merged.
| sha256 = "4018e97c93f97680f1650ffd2a7530245b864ac543fd24fae8c02ba447cb2864", | ||
| urls = [ | ||
| "https://github.com/bazelbuild/rules_java/releases/download/6.5.2/rules_java-6.5.2.tar.gz", | ||
| "https://github.com/bazelbuild/rules_java/releases/download/7.3.1/rules_java-7.3.1.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating rules_java from 6.5.2 to 7.3.1 is a notable version jump. The 7.x series of rules_java introduces some important changes, including:
- The default Java toolchain is now based on JDK 17 (previously JDK 11).
- Bazel 6.0.0 or newer is required.
Could you confirm if:
- The project has been tested with these new defaults, particularly the implications of using JDK 17 by default?
- The Bazel version currently used by the project meets the new minimum requirement of 6.0.0+?
Understanding these aspects is crucial for ensuring a smooth upgrade. It might also be beneficial to explicitly state any necessary configuration changes or testing performed in the PR description.
Summary by CodeRabbit