fix(swift): don't overwrite decimal encoding/decoding methods #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
approved these changes
Feb 5, 2025
algolia-bot
added a commit
that referenced
this pull request
Feb 5, 2025
… (generated) [skip ci] Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Feb 5, 2025
…ted) algolia/api-clients-automation#4428 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
fixes algolia/algoliasearch-client-swift#876
OpenAPI Generator overrides the default decoding/encoding methods for Decimal to be able to decode/encode from strings, in order to avoid losing precision
If users work with Decimal, it will override the default behavior for them
Also, we don't use the Decimal type in our specs, so it shouldn't be an issue for us
{ "type": "string", "format": "decimal" }, but we should avoid that and prefer a number type directlyChanges included: