Skip to content

fix(swift): don't overwrite decimal encoding/decoding methods #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix(swift): don't overwrite decimal encoding/decoding methods #4428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions clients/algoliasearch-client-swift/Sources/Core/Helpers/Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,18 +161,6 @@ public extension KeyedEncodingContainerProtocol {
try self.encodeMap(pairs)
}
}

mutating func encode(_ value: Decimal, forKey key: Self.Key) throws {
var mutableValue = value
let stringValue = NSDecimalString(&mutableValue, Locale(identifier: "en_US"))
try self.encode(stringValue, forKey: key)
}

mutating func encodeIfPresent(_ value: Decimal?, forKey key: Self.Key) throws {
if let value {
try self.encode(value, forKey: key)
}
}
}

public extension KeyedDecodingContainerProtocol {
Expand Down Expand Up @@ -213,34 +201,6 @@ public extension KeyedDecodingContainerProtocol {

return map
}

func decode(_ type: Decimal.Type, forKey key: Self.Key) throws -> Decimal {
let stringValue = try decode(String.self, forKey: key)
guard let decimalValue = Decimal(string: stringValue) else {
let context = DecodingError.Context(
codingPath: [key],
debugDescription: "The key \(key) couldn't be converted to a Decimal value"
)
throw DecodingError.typeMismatch(type, context)
}

return decimalValue
}

func decodeIfPresent(_ type: Decimal.Type, forKey key: Self.Key) throws -> Decimal? {
guard let stringValue = try decodeIfPresent(String.self, forKey: key) else {
return nil
}
guard let decimalValue = Decimal(string: stringValue) else {
let context = DecodingError.Context(
codingPath: [key],
debugDescription: "The key \(key) couldn't be converted to a Decimal value"
)
throw DecodingError.typeMismatch(type, context)
}

return decimalValue
}
}

extension HTTPURLResponse {
Expand Down