Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented Apr 1, 2025

🧭 What and Why

Use the .java-version from the client to make sure it's valid, otherwise we only test it during a release at the very end.
Also use the same file for local dev.

@millotp millotp requested a review from a team as a code owner April 1, 2025 15:07
@millotp millotp requested review from morganleroi and shortcuts April 1, 2025 15:07
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 1, 2025

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1629
go 1615
php 1458
csharp 1376
java 1082
python 1079
ruby 611
swift 491
scala 23

shortcuts
shortcuts previously approved these changes Apr 1, 2025
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update renovate?

@shortcuts shortcuts enabled auto-merge (squash) April 1, 2025 16:24
@shortcuts shortcuts merged commit 9a92af2 into main Apr 1, 2025
28 checks passed
@shortcuts shortcuts deleted the fix/java-version branch April 1, 2025 16:24
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants