Skip to content

chore(scripts): reuse java-version #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025
Merged

chore(scripts): reuse java-version #4696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbdc14e
chore(scripts): reuse java-version
millotp Apr 1, 2025
70e7d48
symlink
millotp Apr 1, 2025
a7a3d50
revert
millotp Apr 1, 2025
f9e4d01
other
millotp Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:
uses: actions/[email protected]
with:
distribution: zulu
java-version-file: config/.java-version
java-version-file: clients/algoliasearch-client-java/.java-version

- name: Setup gradle
if: inputs.type != 'minimal'
Expand Down
2 changes: 1 addition & 1 deletion clients/algoliasearch-client-java/.java-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
21.0.6+7.0.LTS
21.0.6
1 change: 0 additions & 1 deletion config/.java-version
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/ci/githubActions/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ function getVersionFileForLanguage(lang: Language): string {

// jvm lang rely on the same java version
if (lang === 'kotlin' || lang === 'java' || lang === 'scala') {
return 'config/.java-version';
return 'clients/algoliasearch-client-java/.java-version';
}

return `config/.${lang}-version`;
Expand Down
1 change: 1 addition & 0 deletions scripts/docker/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#! /bin/bash

export NODE_VERSION=$(cat .nvmrc)
export JAVA_VERSION=$(cat clients/algoliasearch-client-java/.java-version)

while read line; do
arr=($line)
Expand Down
Loading