fix(specs): you cannot save composition / composition rules only with getSettings ACL
#5334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaraMuller
requested review from
a team,
millotp and
morganleroi
and removed request for
a team
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
ClaraMuller
changed the title
getSettings ACL
aiordache
reviewed
Sep 10, 2025
| - Rules | ||
| operationId: getRule | ||
| x-acl: | ||
| - editSettings |
There was a problem hiding this comment.
Do we need editSettings ACL for retrieval?
There was a problem hiding this comment.
No it is more the other way around.
You can send a get request with the editSettings ACL
ClaraMuller
force-pushed
the
clara/fix/acls
branch
from
3b90e53 to
b8e091b
Compare
aiordache
approved these changes
Sep 11, 2025
shortcuts
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Fix some ACLs mistakes for composition API endpoints.
Stacked on #5332
🎟 JIRA Ticket: contributes to https://algolia.atlassian.net/browse/CMP-487
🧪 Test
yarn cli build specs allyarn cli build clients javascript