Skip to content

fix(specs): you cannot save composition / composition rules only with getSettings ACL #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
+1 −4
Merged

fix(specs): you cannot save composition / composition rules only with getSettings ACL #5334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f456ca
fix(specs): you cannot save composition / composition rules only with
ClaraMuller Sep 9, 2025
b8e091b
fix: rebase
ClaraMuller Sep 11, 2025
30a0091
Merge branch 'main' into clara/fix/acls
ClaraMuller Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions specs/composition-full/paths/compositions/composition.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ put:
operationId: putComposition
x-acl:
- editSettings
- settings
summary: Upsert a composition
description: |
Upsert a composition in the current Algolia application.
Expand Down Expand Up @@ -73,7 +72,6 @@ delete:
operationId: deleteComposition
x-acl:
- editSettings
- settings
summary: Delete a composition
description: |
Delete a composition from the current Algolia application.
Expand Down
3 changes: 1 addition & 2 deletions specs/composition-full/paths/rules/rule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ get:
- Rules
operationId: getRule
x-acl:
- editSettings
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need editSettings ACL for retrieval?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is more the other way around.
You can send a get request with the editSettings ACL

- settings
summary: Retrieve a rule
description: |
Expand Down Expand Up @@ -34,7 +35,6 @@ put:
operationId: putCompositionRule
x-acl:
- editSettings
- settings
summary: Upsert a composition rule
description: |
Upsert a Composition Rule for the specified composition ID.
Expand Down Expand Up @@ -78,7 +78,6 @@ delete:
operationId: deleteCompositionRule
x-acl:
- editSettings
- settings
summary: Delete a Composition Rule
description: |
Delete a Composition Rule from the specified Composition ID.
Expand Down