Skip to content

Conversation

@ClaraMuller
Copy link
Contributor

🧭 What and Why

Modify some tests value after receiving feedback that the documentation could be clearer.

Changes included:

Rename value for composition.behaviour.injection.injectedItems[].key to emphasize that the value in the request is matching the one in the composition entity.

🧪 Test

CI

@ClaraMuller ClaraMuller requested review from a team and seafoox September 30, 2025 20:02
@ClaraMuller ClaraMuller requested a review from a team as a code owner September 30, 2025 20:02
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 30, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 4f1da1c86bb9a3d8d6d0ec3500f4ee067249c157
🍃 Generated commit b2cf7d98d3a102cbbc4dfdfe6e309b07522355a2
🌲 Generated branch generated/clara/specs/clarify-doc-goupe-key
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1780
javascript 1612
php 1447
csharp 1254
python 1191
java 1003
ruby 770
swift 594
scala 23

@ClaraMuller ClaraMuller changed the title tests(composition): Update some tests values to make the documentation clearer test(cts): update some composition client tests values to make the documentation clearer Sep 30, 2025
@ClaraMuller ClaraMuller force-pushed the clara/specs/clarify-doc-goupe-key branch from d78a389 to d6bae7f Compare October 1, 2025 09:34
@ClaraMuller ClaraMuller force-pushed the clara/specs/clarify-doc-goupe-key branch from d6bae7f to 8d4ddc0 Compare October 1, 2025 09:35
@ClaraMuller ClaraMuller requested a review from e-krebs October 1, 2025 09:41
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@millotp millotp enabled auto-merge (squash) October 2, 2025 12:56
@millotp millotp merged commit 97d8ffb into main Oct 2, 2025
29 checks passed
@millotp millotp deleted the clara/specs/clarify-doc-goupe-key branch October 2, 2025 13:13
algolia-bot added a commit that referenced this pull request Oct 2, 2025
…cumentation clearer (#5419) (generated) [skip ci]

Co-authored-by: Clara Muller <[email protected]>
Co-authored-by: Pierre Millot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants