Skip to content

Conversation

ClaraMuller
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-594

Changes included:

  • Enrich the documentation for facets query parameter with features that are only implemented within Composition API.
    For that, remove the link toward Search API doc and create a facets section within Composition API query parameter.
  • Add this parameter as a potential value for run endpont as it is allowed in the payload

🧪 Test

  • CI
  • Run locally yarn cli build specs all && yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team October 14, 2025 19:29
@ClaraMuller ClaraMuller requested a review from a team as a code owner October 14, 2025 19:29
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 14, 2025

🪓 The generated code will be pushed at the end of the CI.

Action triggered by commit e8b35cd1329d0d52db84f3fe5b492ea91c66d01b.

Please do not push any generated code to this pull request.

@ClaraMuller ClaraMuller force-pushed the clara/feat/doc-for-disjunctive-faceting branch from eb46180 to c2c73e5 Compare October 14, 2025 19:32
@ClaraMuller ClaraMuller force-pushed the clara/feat/doc-for-disjunctive-faceting branch from c2c73e5 to c854cef Compare October 14, 2025 19:35
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats a tricky one !

# ### Category Faceting ###
# #########################

facets:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facets is already defined in the IndexSettings.yml file, and since it's imported in the composition spec, it will clash with this one and produce unpredictable naming, like IndexSettingsFacets.

It's not possible to override a model like that, either you would have to copy the entire IndexSettings.yml in here and edit the facets, or you need to rename this to something else like compositionFacets, but the facets object will still be generated with the other spec since it comes first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@millotp why does it workd for enableRules then ? It is exactly the same use case.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you take a look at the bundled spec it's the same issue, but by luck the one from composition was generated first for this one. I don't know how to control the order to prioritize the one from the composition spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but the Search API client is not disturbed by the Composition one in that case ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the type is still generated because it's used inside of the BaseSearchResponse.
I think the only solution is to copy the common spec into the composition spec sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants