-
Notifications
You must be signed in to change notification settings - Fork 26
feat(specs): add specific documentation for facets
query parameter in Composition API
#5477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🪓 The generated code will be pushed at the end of the CI.Action triggered by commit Please do not push any generated code to this pull request. |
eb46180
to
c2c73e5
Compare
…in Composition API
c2c73e5
to
c854cef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats a tricky one !
# ### Category Faceting ### | ||
# ######################### | ||
|
||
facets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facets
is already defined in the IndexSettings.yml
file, and since it's imported in the composition spec, it will clash with this one and produce unpredictable naming, like IndexSettingsFacets
.
It's not possible to override a model like that, either you would have to copy the entire IndexSettings.yml
in here and edit the facets
, or you need to rename this to something else like compositionFacets
, but the facets
object will still be generated with the other spec since it comes first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@millotp why does it workd for enableRules
then ? It is exactly the same use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you take a look at the bundled spec it's the same issue, but by luck the one from composition was generated first for this one. I don't know how to control the order to prioritize the one from the composition spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but the Search API client is not disturbed by the Composition one in that case ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the type is still generated because it's used inside of the BaseSearchResponse
.
I think the only solution is to copy the common spec into the composition spec sorry
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-594
Changes included:
facets
query parameter with features that are only implemented within Composition API.For that, remove the link toward Search API doc and create a
facets
section within Composition API query parameter.run
endpont as it is allowed in the payload🧪 Test
yarn cli build specs all && yarn cli build clients javascript