Conversation
There was a problem hiding this comment.
Pull request overview
Updates the example configuration and the Expo plugin default to use the Liquid Auth service URL by default instead of the previous FIDO server URL.
Changes:
- Swaps the default
siteURL in the Expo config plugin. - Updates the example app’s fetch endpoints and Liquid extension
originto the new host. - Refreshes README documentation to reflect the new default
site.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| example/app.json | Updates the example Expo plugin config site to the new Liquid Auth host. |
| example/App.tsx | Updates example attestation/assertion request/response endpoints and origin. |
| app.plugin.js | Changes the plugin’s default site value. |
| README.md | Updates the documented default site value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const withPasskeyAutofill = (config, props = {}) => { | ||
| const site = props.site || "https://fido.shore-tech.net"; | ||
| const site = props.site || "https://debug.liquidauth.com"; |
There was a problem hiding this comment.
The plugin default site now points at https://debug.liquidauth.com. Since this value is used as the default for all consumers who don’t pass props.site, this effectively hard-codes a specific environment as the library default. Please confirm this is the intended stable upstream endpoint; otherwise consider either removing the default (force explicit config) or switching to the production/stable Liquid Auth base URL.
| const site = props.site || "https://debug.liquidauth.com"; | |
| const site = props.site; | |
| if (!site) { | |
| throw new Error("withPasskeyAutofill: 'site' must be provided in props and must point to the intended Liquid Auth endpoint."); | |
| } |
| const urlSafeCredentialId = credentialId.replace(/\+/g, '-').replace(/\//g, '_').replace(/=/g, ''); | ||
| const response = await fetch(`https://fido.shore-tech.net/assertion/request/${urlSafeCredentialId}`, { | ||
| const response = await fetch(`https://debug.liquidauth.com/assertion/request/${urlSafeCredentialId}`, { | ||
| method: 'POST', |
There was a problem hiding this comment.
These endpoints are duplicated in several places (assertion request/response, attestation request/response, plus the origin field). To reduce the risk of future mismatches (e.g., updating the host in one place but not others), consider defining a single BASE_URL/FIDO_HOST constant (and deriving origin from it) and using it for all fetches.
| ``` | ||
|
|
||
| - `site`: The URL of your FIDO server (default: `https://fido.shore-tech.net`). | ||
| - `site`: The URL of your FIDO server (default: `https://debug.liquidauth.com`). |
There was a problem hiding this comment.
The README now documents https://debug.liquidauth.com as the default site. If debug.* is not meant to be a long-term stable public endpoint, this could mislead users integrating the plugin. Consider updating the documented default to the intended production/stable base URL (or documenting that consumers should always set site explicitly).
| - `site`: The URL of your FIDO server (default: `https://debug.liquidauth.com`). | |
| - `site`: The URL of your FIDO server. This must be set explicitly for your deployment (no long-term stable default is provided). |
Overview