Skip to content

fix: update service url #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhearZero merged 1 commit into from
Mar 31, 2026
+8 −8
Merged

fix: update service url #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ If you are using Expo, you can configure the plugin in your `app.json` or `app.c
}
```

- `site`: The URL of your FIDO server (default: `https://fido.shore-tech.net`).
- `site`: The URL of your FIDO server (default: `https://debug.liquidauth.com`).
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README now documents https://debug.liquidauth.com as the default site. If debug.* is not meant to be a long-term stable public endpoint, this could mislead users integrating the plugin. Consider updating the documented default to the intended production/stable base URL (or documenting that consumers should always set site explicitly).

Suggested change
- `site`: The URL of your FIDO server (default: `https://debug.liquidauth.com`).
- `site`: The URL of your FIDO server. This must be set explicitly for your deployment (no long-term stable default is provided).

Copilot uses AI. Check for mistakes.
- `label`: The name of the credential provider as it appears in Android settings (default: `My Credential Provider`).

## Usage
Expand Down
2 changes: 1 addition & 1 deletion app.plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const withUserAgent = (config) => {
};

const withPasskeyAutofill = (config, props = {}) => {
const site = props.site || "https://fido.shore-tech.net";
const site = props.site || "https://debug.liquidauth.com";
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin default site now points at https://debug.liquidauth.com. Since this value is used as the default for all consumers who don’t pass props.site, this effectively hard-codes a specific environment as the library default. Please confirm this is the intended stable upstream endpoint; otherwise consider either removing the default (force explicit config) or switching to the production/stable Liquid Auth base URL.

Suggested change
const site = props.site || "https://debug.liquidauth.com";
const site = props.site;
if (!site) {
throw new Error("withPasskeyAutofill: 'site' must be provided in props and must point to the intended Liquid Auth endpoint.");
}

Copilot uses AI. Check for mistakes.
const label = props.label || "My Credential Provider";

config = withAndroidCookieModule(config);
Expand Down
10 changes: 5 additions & 5 deletions example/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function AppContent() {
}

const urlSafeCredentialId = credentialId.replace(/\+/g, '-').replace(/\//g, '_').replace(/=/g, '');
const response = await fetch(`https://fido.shore-tech.net/assertion/request/${urlSafeCredentialId}`, {
const response = await fetch(`https://debug.liquidauth.com/assertion/request/${urlSafeCredentialId}`, {
method: 'POST',
Comment on lines 94 to 96
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These endpoints are duplicated in several places (assertion request/response, attestation request/response, plus the origin field). To reduce the risk of future mismatches (e.g., updating the host in one place but not others), consider defining a single BASE_URL/FIDO_HOST constant (and deriving origin from it) and using it for all fetches.

Copilot uses AI. Check for mistakes.
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
Expand All @@ -109,7 +109,7 @@ function AppContent() {
console.log(options)
const result = await Passkey.get(options);

const submitResponse = await fetch('https://fido.shore-tech.net/assertion/response', {
const submitResponse = await fetch('https://debug.liquidauth.com/assertion/response', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(result),
Expand Down Expand Up @@ -152,7 +152,7 @@ function AppContent() {

await ReactNativePasskeyAutofill.setHdRootKeyId(ed25519Key.metadata.parentKeyId)

const response = await fetch('https://fido.shore-tech.net/attestation/request', {
const response = await fetch('https://debug.liquidauth.com/attestation/request', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
Expand Down Expand Up @@ -183,7 +183,7 @@ function AppContent() {
...result.clientExtensionResults,
liquid: {
requestId: 'example-session-' + Date.now(),
origin: 'fido.shore-tech.net',
origin: 'debug.liquidauth.com',
type: 'algorand',
address: encodeAddress(new Uint8Array(ed25519Key.publicKey)),
signature: toBase64URL(signature),
Expand All @@ -192,7 +192,7 @@ function AppContent() {
};
}

const submitResponse = await fetch('https://fido.shore-tech.net/attestation/response', {
const submitResponse = await fetch('https://debug.liquidauth.com/attestation/response', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(result),
Expand Down
2 changes: 1 addition & 1 deletion example/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
[
"@algorandfoundation/react-native-passkey-autofill",
{
"site": "https://fido.shore-tech.net"
"site": "https://debug.liquidauth.com"
}
]
]
Expand Down
Loading