feat: display forum post council note on proposal detail page#212
Open
simonbelingar wants to merge 2 commits intoalgorandfoundation:mainfrom
Open
feat: display forum post council note on proposal detail page#212simonbelingar wants to merge 2 commits intoalgorandfoundation:mainfrom
simonbelingar wants to merge 2 commits intoalgorandfoundation:mainfrom
Conversation
kylebeee
requested changes
Mar 16, 2026
Collaborator
kylebeee
left a comment
kylebeee
left a comment
There was a problem hiding this comment.
love it!
Lets make a small change & include screenshots
| } | ||
|
|
||
| const [forumNotice, setForumNotice] = useState<string | null>(null); | ||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
fetch inside useEffect is generally an anti-pattern.
Lets put this inside a tanstack query
Author
There was a problem hiding this comment.
should be sorted, lmk if any extra changes needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ Overview
Fetches the Discourse post notice from the proposal's forum link and displays it above the proposal title on the proposal detail page.
/api/discourse/[id]server-side proxy to avoid CORS issues