Skip to content

feat: display forum post council note on proposal detail page #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonbelingar wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −2
Open

feat: display forum post council note on proposal detail page #212

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b891f6
feat: display forum post notice on proposal detail page
simonbelingar Mar 16, 2026
87e0fee
useffect replaced with usequerry
simonbelingar Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/recipes/proposal/ProposalView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,26 @@ export function ProposalInfo({

const phase = getProposalStatusPhase(proposal);

function colorizeVotes(html: string): string {
return html
.replace(/\b([0-9]|1[01])\s+yes\b/g, '<br/><span style="color:#22c55e">$1 yes</span>')
.replace(/\b([0-9]|1[01])\s+no\b/g, '<span style="color:#ef4444"> / $1 no</span>')
.replace(/\b([0-9]|1[01])\s+abstain\b/g, '<span style="color:#eab308"> / $1 abstain</span>');
}

const [forumNotice, setForumNotice] = useState<string | null>(null);
useEffect(() => {

@kylebeee kylebeee Mar 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch inside useEffect is generally an anti-pattern.

Lets put this inside a tanstack query

@simonbelingar simonbelingar Mar 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be sorted, lmk if any extra changes needed

image image

if (!proposal.forumLink) return;
const topicId = proposal.forumLink.split("/").filter(Boolean).pop();
fetch(`/api/discourse/${topicId}`)
.then((r) => r.json())
.then((data) => {
const notice = data.post_stream?.posts?.[0]?.notice;
if (notice?.cooked) setForumNotice(notice.cooked);
})
.catch(() => {});
}, [proposal.forumLink]);

const _pastProposals = (pastProposals || []).filter((p) =>
![
ProposalStatus.ProposalStatusEmpty,
Expand Down Expand Up @@ -1043,6 +1063,11 @@ export function ProposalInfo({
<div className="lg:col-span-2 lg:grid lg:w-full lg:max-w-7xl lg:grid-cols-2 lg:gap-x-8 pt-6">
<div className="lg:pr-4">
<div className="sm:max-w-lg md:max-w-[unset]">
{forumNotice && (
<p className="text-sm text-algo-black-70 dark:text-algo-black-30 mb-2">
<span dangerouslySetInnerHTML={{ __html: colorizeVotes(forumNotice) }} />
</p>
)}
<p className="text-base/7 text-algo-blue">
<BracketedPhaseDetail phase={phase} />
</p>
Expand Down