drivers: sdhc: Add synopsys dwc sdhc driver#439
Open
Deepak-AlifSemi wants to merge 1 commit intoalifsemi:mainfrom
Open
drivers: sdhc: Add synopsys dwc sdhc driver#439Deepak-AlifSemi wants to merge 1 commit intoalifsemi:mainfrom
Deepak-AlifSemi wants to merge 1 commit intoalifsemi:mainfrom
Conversation
b07e2bb to
887f62c
Compare
a924014 to
1277abc
Compare
There was a problem hiding this comment.
Pull request overview
Adds an initial Zephyr SDHC driver for Alif SoCs and wires it up via devicetree and Kconfig so boards can use the new "alif,sdhc" compatible.
Changes:
- Introduce
alif,sdhcdevicetree binding and switch Alif DTS nodes to use it. - Add a new
sdhc_alifdriver implementation with DMA (ADMA2/SDMA) support and IRQ handling. - Register the driver in SDHC Kconfig/CMake so it builds when enabled.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| dts/bindings/sdhc/alif,sdhc.yaml | New DT binding for the Alif SDHC controller (interrupts, pinctrl, optional GPIOs). |
| dts/arm/alif/ensemble/common/e1c.dtsi | Switch SDHC node compatible to "alif,sdhc". |
| dts/arm/alif/ensemble/common/e1.dtsi | Switch compatible and update interrupts/interrupt-names and max bus frequency. |
| dts/arm/alif/balletto/common/b1.dtsi | Switch SDHC node compatible to "alif,sdhc". |
| drivers/sdhc/sdhc_alif.h | New register definitions and helper macros for the Alif SDMMC controller. |
| drivers/sdhc/sdhc_alif.c | New Alif SDHC driver implementation (init, IO, DMA, IRQ, tuning). |
| drivers/sdhc/Kconfig.alif | New Kconfig options for enabling Alif SDHC + DMA mode selection. |
| drivers/sdhc/Kconfig | Source the new Alif Kconfig. |
| drivers/sdhc/CMakeLists.txt | Compile the new driver when CONFIG_SDHC_ALIF is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
954b2b8 to
3dc7abb
Compare
6e9bca0 to
b40b9a6
Compare
Added initial version of synopsys dwc sdhc driver. Supports 3.3v and 1.8v operation. Supports SD/SDIO modes at 1, 4 bit bus, 400khz, 25mhz, 50mhz speed. Signed-off-by: Deepak Kumar <deepak@alifsemi.com>
b40b9a6 to
66403d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added initial version of synopsys dwc sdhc driver.
Supports 3.3v and 1.8v operation.
Supports SD/SDIO modes at 1, 4 bit bus, 400khz, 25mhz, 50mhz speed.