hotel, anchored search and a lot of others calls and tags#336
hotel, anchored search and a lot of others calls and tags#336gabrieleleo wants to merge 102 commits intoamabnl:masterfrom
Conversation
Conflicts: src/Amadeus/Client.php src/Amadeus/Client/RequestOptions/FareMasterPricerTbSearch.php src/Amadeus/Client/Struct/Fare/MasterPricer/FareOptions.php src/Amadeus/Client/Struct/Fare/MasterPricerTravelBoardSearch.php tests/Amadeus/Client/Struct/Fare/MasterPricerTravelBoardSearchTest.php
…ng classmap and multiwsdl
- Service_StandaloneCatalogue Message is added
New Message Service_StandaloneCatalogue implementation
ServiceStandaloneCatalogue Changes
master to hotel
|
It's very good that there are a lot of working functionality, but it's need a huge refactor for such library and also unit tests anyway. I'll see how I can help here... |
would be great. our developers really love this library but they don't use unit test for it, we've start to implement a lot of things, also train in future. |
|
It's great to have so many features, but you'll have to split them up. I can't review one giant blob of files properly, plus, it's got merge conflicts. If you were to start for example by extracting all Hotel message changes into a separate pull request, and work from there, we can get somewhere. But these are too many changes for a single pull request. |
…Repository refactored code, removed duplicates and removed IDE specific comments
7 participants
our developers have develop a lot of new stuff for your library, unfortunately they have commit everythings in master and without test unit in module. we don't have time to do that kind of stuff for this module, but our version run without any problem at all and have hotel.
can anyone help?