remove stale code

[sallyom]

Remove stale RFE workflow code from frontend following the UI refactor in commit 1540e30. This cleanup eliminates unused API services, type definitions, and workflow phase constants.

Files removed:

• components/frontend/src/services/api/rfe.ts (270 lines)
• components/frontend/src/types/api/rfe.ts (154 lines)

Files modified:

• Remove RFE exports from API and type index files
• Remove stale RFE types from agentic-session.ts (83 lines)
• Remove workflow phase constants from lib/agents.ts (20 lines)

Build verified: 0 errors, 0 warnings

🤖 Generated with Claude Code

[github-actions]

Claude Code Review

Summary

This PR effectively removes stale RFE workflow code from the frontend following the UI refactor in commit 1540e30. The cleanup is well-scoped, complete, and safe. All 6 files are properly handled with no broken imports or references remaining.

Overall Assessment: ✅ APPROVED - Ready to merge

---

Issues by Severity

🟢 No Critical Issues Found

All checks passed successfully.

---

Positive Highlights

Code Quality ✨

• Clean deletion: All RFE-related files removed completely (424 lines deleted)
• Proper index cleanup: Both services/api/index.ts and types/api/index.ts properly updated to remove RFE exports
• No orphaned code: Verified no remaining imports or references to deleted types
• Surgical precision: Only removed frontend RFE code; backend RFE infrastructure intentionally preserved

Best Practices Followed 📋

• ✅ Build verification: PR description confirms "0 errors, 0 warnings"
• ✅ Proper git hygiene: Single focused commit with clear message
• ✅ Documentation: PR body clearly lists all affected files
• ✅ No breaking changes: Workflow management feature (OOTB workflows) still works via separate workflows.ts API

Architecture Consistency 🏗️

• Correctly identified that use-workflows.ts, use-workflow-management.ts, and session page workflow features are for OOTB workflows, not RFE workflows
• These files use @/services/api/workflows (which still exists) and are unaffected
• Clear separation of concerns maintained

---

Verification Performed

I performed the following checks:

1. ✅ Import analysis: No broken imports to deleted files
2. ✅ Type reference search: No remaining references to RFEWorkflow, WorkflowPhase, ArtifactFile types
3. ✅ Export validation: API and type index files properly cleaned
4. ✅ OOTB workflow isolation: Confirmed workflow management features use separate workflows.ts API
5. ✅ Backend preservation: Backend RFE code intentionally left intact

---

Recommendations

✅ Ready to Merge

No action items required. This is a clean, well-executed code cleanup.

Optional Future Enhancements

(Not blockers for this PR - can be addressed separately)

1. Comprehensive cleanup: Consider following up with backend RFE cleanup if the feature is fully deprecated
2. Documentation update: If RFE workflows are being replaced, update relevant docs to guide users to the new approach

---

Technical Details

Files Deleted (527 lines total)

• services/api/rfe.ts (269 lines) - RFE API client methods
• types/api/rfe.ts (153 lines) - RFE type definitions
• Type exports from types/agentic-session.ts (77 lines) - Inline RFE types
• Workflow constants from lib/agents.ts (22 lines) - Phase labels and descriptions

Files Modified (Clean Exports)

• services/api/index.ts - Removed export * as rfeApi from './rfe'
• types/api/index.ts - Removed export * from './rfe'

Validation

• No TypeScript errors expected (all deleted types were isolated)
• No runtime errors (no components importing deleted modules)
• Build confirmed clean per PR description

---

Review completed by Claude Code 🤖
Generated with thoroughness level: comprehensive