Skip to content

Build improvements#239

Merged
amitdev merged 4 commits intoamitdev:masterfrom
adangel:build-improvements
May 24, 2025
Merged

Build improvements#239
amitdev merged 4 commits intoamitdev:masterfrom
adangel:build-improvements

Conversation

@adangel
Copy link
Contributor

@adangel adangel commented May 23, 2025

This contains three changes:

  • build against 2023.3 as recommended. 2023.3 (233) is the oldest supported version
    @jborgers you changed this in ba4c03b - I assume by accident?
  • Disable caching for the verify job.
    This is a follow up on New release 2.0.4 not available #221. Hopefully, the future releases run smoothly then.
  • The property pluginVerifierIdeVersions was not used. The IDE versions to test against are determined automatically based on platformVersion (recommended()). With platformVersion=2023.3, verifyPlugin will execute verification against 2023.3.x, 2024.1.x, 2024.2.x, 2024.3.x, 2025.1.x and 2025.2.x. These are right now 6 versions, with each consuming at least 3GB we are already at 18GB... I guess, once 2025.2 is released, we should drop support for 2023.3.

Some background info on the caching problem: A similar problem is described in JetBrains/intellij-platform-plugin-template#462 . We could do the suggestion in the last comment and verify only against the earliest and latest release. But it would have the downside, that we might not see any incompatibilities. That's why I prefer to test the whole range.
The action gradle/action/setup-gradle does already much to reduce the cache sizes (see https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#select-which-branches-should-write-to-the-cache ), e.g. caches are only written from the main/master (default) branch and not from pull requests. But pull requests can still benefit from the cache from the default branch.

Note: Verification currently fails due to #238.

adangel and others added 4 commits May 22, 2025 18:10
- build against 2023.3 as recommended. 2023.3 (233) is the oldest supported version.
This should avoid that we hit the 10GB limit on GitHub.

Also remove the plugin verifier cache, as it is not
used anymore by the verifier plugin. The IDEs are
now gradle dependencies and would be stored in the
gradle cache.
@amitdev amitdev merged commit 59a0604 into amitdev:master May 24, 2025
4 checks passed
@jborgers
Copy link
Collaborator

jborgers commented May 24, 2025

👍
@adangel Something didn't work when building on my side with 2023.3; changing it to 2024.1 solved it.
I propose to only support 3 versions of IntelliJ. This will mean less maintenance work to support all versions, less test/verify time and less memory usage.

@adangel
Copy link
Contributor Author

adangel commented May 29, 2025

I propose to only support 3 versions of IntelliJ. This will mean less maintenance work to support all versions, less test/verify time and less memory usage.

I'd like to keep the 2023.3 compatibility, if possible. I'm working for a customer who is unfortunately stuck for a while on 2023.3...

@adangel adangel deleted the build-improvements branch May 29, 2025 10:25
@jborgers
Copy link
Collaborator

jborgers commented Jun 3, 2025

@adangel I am curious why they are stuck?
I just tested the plugin with PR #246 in 2023.3 and it works :-)

@adangel
Copy link
Contributor Author

adangel commented Jun 9, 2025

@adangel I am curious why they are stuck?

I don't know exactly. It's a combination of priorities and effort. E.g. they need to find and verify the flags to prevent IntelliJ from calling home (which won't work in the corporate network anyway).

I just tested the plugin with PR #246 in 2023.3 and it works :-)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants