fix: correct neovim utils script path reference #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change incorrect reference from 'neovim_utils.sh' to 'utils/neovim.sh'. The wrong path was causing chmod failures during remote neovim installation. Updates provider code and corresponding tests.
thienandangthanh
force-pushed
the
fix/incorrect-script-installation-file-reference
branch
from
62de0a4 to
e24e281
Compare
Signed-off-by: Amit Singh <amitds1997@gmail.com>
Signed-off-by: Amit Singh <amitds1997@gmail.com>
Signed-off-by: Amit Singh <amitds1997@gmail.com>
Owner
|
Thanks for the PR @thienandangthanh! We just fixed a single script in the path, we had to do that and fix how the architecture is passed downstream to the install script to get this going! I pushed commits to your PR, hope you do not mind! |
This was
linked to
issues
Aug 21, 2025
Owner
|
Fixes #203 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #220
Change incorrect reference from 'neovim_utils.sh' to 'utils/neovim.sh'. The wrong path was causing chmod failures during remote neovim installation.
Updates provider code and corresponding tests.
All the tests are passed with
make clean-testand GitHub CI workflow https://github.com/thienandangthanh/remote-nvim.nvim/actions/runs/16680051261