dev/ad4080 adalm_mmsc by nacuna-adi · Pull Request #2697 · analogdevicesinc/no-OS

nacuna-adi · 2025-08-14T02:56:59Z

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

CLAassistant · 2025-08-14T02:57:05Z

All committers have signed the CLA.

jemfgeronimo · 2025-08-14T07:53:37Z

/AzurePipelines run

azure-pipelines · 2025-08-14T07:53:48Z

Azure Pipelines successfully started running 2 pipeline(s).

amiclaus

hi, there are multiple builds failing on your PR, please make sure you fix those issues prior to the in-depth review.

thorenscientific · 2025-08-27T22:58:27Z

@nacuna-adi :

on the naming of the project - rather than "ad4080", consider naming it "adalm-mmsc". That allows you to go beyond just the AD4080, add gpio / one-bit-adc-dacs for frequency control, heartbeat LED, and other features specific to this setup. there is precedent, see the swiot1l project.
Update iio attribute names and add missing attributes to be consistent with the upstreamed Linux driver. This should work with the pyadi-iio example in this PR: ad4080: add pyadi-iio support pyadi-iio#669

kister-jimenez · 2025-09-18T03:56:19Z

/AzurePipelines run

azure-pipelines · 2025-09-18T03:56:26Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

kister-jimenez · 2025-09-18T04:02:17Z

@nacuna-adi
Can you split the commits into changes in the existing driver, and the addition of new iio driver, iio driver doc, new project, and new project doc?

Might be good to rename the project folder to ad4080_adalm or something else related to the board if there are components in the board that is not applicable to the original AD4080 evkit.

Rebase to the latest main and resolve conflict on the rst file so the CI can run.

kister-jimenez · 2025-09-18T04:51:46Z

/AzurePipelines run

azure-pipelines · 2025-09-18T04:51:57Z

Azure Pipelines successfully started running 2 pipeline(s).

kister-jimenez · 2025-09-30T01:33:02Z

/AzurePipelines run

azure-pipelines · 2025-09-30T01:33:13Z

Azure Pipelines successfully started running 2 pipeline(s).

buha · 2025-10-03T09:57:37Z

/AzurePipelines run

azure-pipelines · 2025-10-03T09:57:48Z

Azure Pipelines successfully started running 2 pipeline(s).

kister-jimenez · 2025-10-06T03:05:33Z

/AzurePipelines run

kister-jimenez · 2026-01-21T04:34:31Z

/AzurePipelines run

azure-pipelines · 2026-01-21T04:34:44Z

Azure Pipelines successfully started running 2 pipeline(s).

amiclaus

some comments on my side.

drivers/adc/ad4080/iio_ad4080.c

drivers/adc/ad4080/ad4080.h

drivers/adc/ad4080/ad4080.c

projects/adalm-mmsc/README.rst

projects/adalm-mmsc/builds.json

projects/adalm-mmsc/src/platform/maxim/main.c

projects/adalm-mmsc/src/platform/maxim/parameters.h

projects/adalm-mmsc/src/common/common_data.h

1) ad4080 driver needs to support user defined GPIO as extended software select pin Signed-off-by: nacuna <niel.acuna@analog.com>

1. add initial source and header file for ad4080 IIO. Signed-off-by: nacuna <niel.acuna@analog.com>

1. Add README.rst documentation file for ad4080 alongside other documentation related files. Signed-off-by: nacuna <niel.acuna@analog.com>

nacuna-adi · 2026-01-22T09:13:21Z

hello @amiclaus , Thank you for your patience. I have addressed newest batch of review comments. Requesting another round of code reviews.

1. Add initial project files for both basic and IIO example for ad4080. Signed-off-by: nacuna <niel.acuna@analog.com>

1. Add README.rst documentation file for adalm-mmsc project alongside other documentation related files. Signed-off-by: nacuna <niel.acuna@analog.com>

drivers/adc/ad4080/ad4080.h

drivers/adc/ad4080/ad4080.c

drivers/adc/ad4080/iio_ad4080.c

drivers/adc/ad4080/README.rst

projects/adalm-mmsc/src/platform/maxim/main.c

nacuna-adi · 2026-01-22T13:53:54Z

hello @amiclaus , thank you for taking the time to review. I have addressed your comments. requesting another round of code reviews.

amiclaus · 2026-01-26T13:36:02Z

/AzurePipelines run

azure-pipelines · 2026-01-26T13:36:15Z

Azure Pipelines successfully started running 2 pipeline(s).

thorenscientific · 2026-01-26T19:18:08Z

@Sean-Smith_adi Do you want to have someone on your team take a look at this?

ssmith73 · 2026-01-27T11:43:30Z

@thorenscientific I'm going to review this with Guru today or tomorrow and ask him to review the changes.

nacuna-adi requested review from CiprianRegus, amiclaus, buha, danmois, dbogdan and rbolboac as code owners August 14, 2025 02:57

amiclaus reviewed Aug 21, 2025

View reviewed changes

nacuna-adi force-pushed the dev/ad4080_adalm branch 2 times, most recently from d7dee6a to 4295a64 Compare September 5, 2025 04:13

thorenscientific mentioned this pull request Sep 6, 2025

ad4080: add pyadi-iio support analogdevicesinc/pyadi-iio#669

Merged

15 tasks

nacuna-adi closed this Sep 18, 2025

nacuna-adi force-pushed the dev/ad4080_adalm branch from 4295a64 to 968583e Compare September 18, 2025 04:35

nacuna-adi reopened this Sep 18, 2025

nacuna-adi force-pushed the dev/ad4080_adalm branch from b202b6b to 20756ef Compare September 23, 2025 00:06

nacuna-adi force-pushed the dev/ad4080_adalm branch from 20756ef to d48e982 Compare October 3, 2025 06:20

nacuna-adi force-pushed the dev/ad4080_adalm branch from d48e982 to 8e43f2d Compare October 6, 2025 02:57

nacuna-adi force-pushed the dev/ad4080_adalm branch 2 times, most recently from e8ad269 to 6bbe618 Compare January 21, 2026 04:05

nacuna-adi requested review from RaduSabau1, cristina-suteu, raezt, ranechita and rbudai98 as code owners January 21, 2026 04:05

amiclaus reviewed Jan 21, 2026

View reviewed changes

nacuna-adi added 3 commits January 22, 2026 17:10

drivers: adc: ad4080: add software SS to ad4080 driver

9675596

1) ad4080 driver needs to support user defined GPIO as extended software select pin Signed-off-by: nacuna <niel.acuna@analog.com>

drivers: adc: ad4080: Add IIO support to ad4080

4a69468

1. add initial source and header file for ad4080 IIO. Signed-off-by: nacuna <niel.acuna@analog.com>

drivers: adc: ad4080: Add README documentation for ad4080

4ab80ed

1. Add README.rst documentation file for ad4080 alongside other documentation related files. Signed-off-by: nacuna <niel.acuna@analog.com>

nacuna-adi force-pushed the dev/ad4080_adalm branch from 6bbe618 to 1acf3e1 Compare January 22, 2026 09:12

nacuna-adi requested a review from amiclaus January 22, 2026 09:14

nacuna-adi added 2 commits January 22, 2026 18:38

projects: adalm-mmsc: Add project for adalm-mmsc

40fd426

1. Add initial project files for both basic and IIO example for ad4080. Signed-off-by: nacuna <niel.acuna@analog.com>

projects: adalm-mmsc: Add README documentation for adalm-mmsc project

261db2b

1. Add README.rst documentation file for adalm-mmsc project alongside other documentation related files. Signed-off-by: nacuna <niel.acuna@analog.com>

nacuna-adi force-pushed the dev/ad4080_adalm branch from 1acf3e1 to 261db2b Compare January 22, 2026 10:38

nacuna-adi requested a review from stefpopa as a code owner January 22, 2026 10:38

amiclaus reviewed Jan 22, 2026

View reviewed changes

nacuna-adi requested a review from amiclaus January 22, 2026 13:56

amiclaus approved these changes Jan 23, 2026

View reviewed changes

danmois approved these changes Jan 26, 2026

View reviewed changes

amiclaus merged commit 1130fc3 into analogdevicesinc:main Feb 6, 2026
14 checks passed

Conversation

nacuna-adi commented Aug 14, 2025

Pull Request Description

PR Type

PR Checklist

Uh oh!

CLAassistant commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jemfgeronimo commented Aug 14, 2025

Uh oh!

azure-pipelines bot commented Aug 14, 2025

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

thorenscientific commented Aug 27, 2025

Uh oh!

kister-jimenez commented Sep 18, 2025

Uh oh!

azure-pipelines bot commented Sep 18, 2025

Uh oh!

kister-jimenez commented Sep 18, 2025

Uh oh!

kister-jimenez commented Sep 18, 2025

Uh oh!

azure-pipelines bot commented Sep 18, 2025

Uh oh!

kister-jimenez commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

buha commented Oct 3, 2025

Uh oh!

azure-pipelines bot commented Oct 3, 2025

Uh oh!

kister-jimenez commented Oct 6, 2025

Uh oh!

kister-jimenez commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nacuna-adi commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nacuna-adi commented Jan 22, 2026

Uh oh!

amiclaus commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

thorenscientific commented Jan 26, 2026

Uh oh!

ssmith73 commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

CLAassistant commented Aug 14, 2025 •

edited

Loading

nacuna-adi commented Jan 22, 2026 •

edited

Loading