Conversation
|
Generated documentation for this PR is available at Link |
Test Results1 690 tests +2 439 ✅ +1 11m 46s ⏱️ -1s Results for commit 4791340. ± Comparison against base commit 9653f85. This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
adi/ad4080.py
Outdated
| # All rights reserved. | ||
| # | ||
| # Redistribution and use in source and binary forms, with or without modification, | ||
| # are permitted provided that the following conditions are met: | ||
| # - Redistributions of source code must retain the above copyright | ||
| # notice, this list of conditions and the following disclaimer. | ||
| # - Redistributions in binary form must reproduce the above copyright | ||
| # notice, this list of conditions and the following disclaimer in | ||
| # the documentation and/or other materials provided with the | ||
| # distribution. | ||
| # - Neither the name of Analog Devices, Inc. nor the names of its | ||
| # contributors may be used to endorse or promote products derived | ||
| # from this software without specific prior written permission. | ||
| # - The use of this software may or may not infringe the patent rights | ||
| # of one or more patent holders. This license does not release you | ||
| # from the requirement that you obtain separate licenses from these | ||
| # patent holders to use this software. | ||
| # - Use of the software either in source or binary form, must be run | ||
| # on or directly connected to an Analog Devices Inc. component. | ||
| # | ||
| # THIS SOFTWARE IS PROVIDED BY ANALOG DEVICES "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, | ||
| # INCLUDING, BUT NOT LIMITED TO, NON-INFRINGEMENT, MERCHANTABILITY AND FITNESS FOR A | ||
| # PARTICULAR PURPOSE ARE DISCLAIMED. | ||
| # | ||
| # IN NO EVENT SHALL ANALOG DEVICES BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
| # EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, INTELLECTUAL PROPERTY | ||
| # RIGHTS, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR | ||
| # BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
| # STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF | ||
| # THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
There was a problem hiding this comment.
Dont need the full license with the SPDX there
tfcollins
left a comment
There was a problem hiding this comment.
License just needs updating. If you also want to add testing to the properties that would increase test usefulness
c5a07b4 to
13bdf8b
Compare
amiclaus
left a comment
There was a problem hiding this comment.
v2:
- use short version for license
- improve tests
|
I verified that this also works with @nacuna-adi 's tinyiiod server running on MAX3266: analogdevicesinc/no-OS#2697 |
| borderaxespad=0.0, | ||
| ) | ||
|
|
||
| plt.show() |
There was a problem hiding this comment.
Is it good practice to put del my_adc at the end? I find at least with serial backend, the script won't run multiple times if the context is left connected. I've tried some basic if my_adc is None and try my_adc constructs, but nothing seems to work cleanly.
Add support for ad4080. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
13bdf8b to
4791340
Compare
amiclaus
left a comment
There was a problem hiding this comment.
v3:
- add
del my_adcat the end of the example
Description
Add support for ad4080.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: