drivers:adc:ltc2378: Add support for LTC2378-20 by csarip · Pull Request #2794 · analogdevicesinc/no-OS

csarip · 2025-10-22T03:14:30Z

Pull Request Description

This PR adds initial driver support for the LTC2378-20 20-bit SAR ADC with project examples.

Driver Features Implemented:

SPI Communication: 20-bit data acquisition with CNV/BUSY handshake protocol
Input Modes: Unipolar (0 to VREF) and bipolar (±VREF) configuration support
Data Conversion: Raw ADC reading and raw-to-microvolts conversion functions
Power Management: Manual power-down control via CNV signal

Project Examples Added:

Platform: Maxim MAX32666FTHR evaluation board with DC2135A board
Test: Validates SPI communication, ADC conversion, unipolar/bipolar modes, and voltage scaling
Hardware Validation: Tested on actual MAX32666FTHR hardware with DC2135A board

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

csarip · 2025-10-23T02:04:10Z

It appears to have the same failed checks as PR #2783. Unless all checks are required to pass, this PR is ready for review.

amiclaus

looks good overall, but the documentation issues ar valid. check for the warnings in the log file, those are treated as errors too.

drivers/adc/ltc2378/ltc2378.c

drivers/adc/ltc2378/iio_ltc2378.c

jemfgeronimo

Some minor changes. The main change is to use the new example infrastructure.
Reference commits: 39e2d46, 81c90dc, 913998c
Reference PRs: #2795, #2421

drivers/adc/ltc2378/ltc2378.c

projects/ltc2378/builds.json

csarip · 2025-10-28T08:56:02Z

v2:

Fixed declarations and brackets
Changed to new example infrastructure

jemfgeronimo

Some changes to fix the LinuxBuilds documentation errors.

drivers/adc/ltc2378/README.rst

projects/ltc2378/README.rst

csarip · 2025-10-29T02:42:26Z

v3:

Added fixes to docs
Fixed commit messages

jemfgeronimo

Some minor changes.

drivers/adc/ltc2378/ltc2378.c

drivers/adc/ltc2378/iio_ltc2378.c

projects/ltc2378/src/common/common_data.c

projects/ltc2378/src/platform/maxim/parameters.h

csarip · 2025-10-30T03:01:11Z

v4:

Fixed IIO error handling by replacing sentinel values with proper error codes
Removed magic numbers by adding descriptive macros
Used no-OS utility functions for sign extension

jemfgeronimo

Just a minor change. Otherwise, LGTM.

drivers/adc/ltc2378/README.rst

csarip · 2025-11-12T07:21:01Z

v5:

Added minor changes in README.rst drivers/adc/ltc2378/README.rst

drivers/adc/ltc2378/ltc2378.c

drivers/adc/ltc2378/iio_ltc2378.c

projects/ltc2378/README.rst

projects/ltc2378/src/examples/iio/iio_example.c

csarip · 2026-02-02T07:59:39Z

v6:

Added return‑status checks and exited on failure.
Added iio read/write support.
Used make EXAMPLE=iio instead of editing the Makefile.
Renamed src/examples/iio_example to src/examples/iio.

drivers/adc/ltc2378/ltc2378.c

projects/ltc2378/src/examples/basic/basic_example.c

drivers/adc/ltc2378/iio_ltc2378.h

drivers/adc/ltc2378/ltc2378.h

drivers/adc/ltc2378/ltc2378.c

csarip · 2026-02-02T10:39:55Z

v7:

Added error checks
Fixed variable declaration at start of function
Fixed formatting
Removed platform-specific headers

drivers/adc/ltc2378/iio_ltc2378.c

projects/ltc2378/src/examples/basic/basic_example.c

projects/ltc2378/src/platform/maxim/main.c

projects/ltc2378/src/common/common_data.h

projects/ltc2378/src/platform/maxim/parameters.h

drivers/adc/ltc2378/iio_ltc2378.h

Add initial header and source files for LTC2378 driver. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

Add initial header and source file for LTC2378 IIO driver. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

Add README.rst documentation file for LTC2378 alongside other documentation related files. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

Add initial project files for both basic and IIO examples for LTC2378. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

csarip · 2026-02-04T06:00:07Z

v8:

Removed redundant UART init from basic example
Added .channel = 0 to IIO channel and #ifdef IIO_SUPPORT
Removed unnecessary includes and fixed error return in main.c

amiclaus

some more comments on my side, otherwise lgtm.

amiclaus · 2026-02-04T11:31:23Z

drivers/adc/ltc2378/ltc2378.c

+{
+	struct ltc2378_dev *dev;
+	int ret;
+


missing init_param null check.

if (!device || !init_param) return -EINVAL;

amiclaus · 2026-02-04T12:20:02Z

drivers/adc/ltc2378/iio_ltc2378.h

+};
+
+struct ltc2378_iio_desc_init_param {
+	struct ltc2378_init_param *ltc2378_init_param;


shouldn't this be a const struct?

amiclaus · 2026-02-04T12:22:45Z

projects/ltc2378/src/examples/basic/basic_example.c

+		int32_t voltage_uv;
+
+		ret = ltc2378_read_raw(dev, &raw);
+		if (ret) {


isn't there a way to exit the while loop in case of errors. and free the resources.

amiclaus · 2026-02-04T12:23:36Z

drivers/adc/ltc2378/iio_ltc2378.h

+
+struct ltc2378_iio_desc {
+	struct ltc2378_dev *ltc2378_dev;
+	struct iio_device *iio_dev;


where does this struct come from? i don't see any relevant include.

csarip requested review from CiprianRegus, amiclaus, buha, danmois, dbogdan and rbolboac as code owners October 22, 2025 03:14

csarip force-pushed the dev/ltc2378-20 branch 3 times, most recently from 8e480e9 to e1c00ca Compare October 22, 2025 07:43

jemfgeronimo self-requested a review October 24, 2025 07:33

amiclaus reviewed Oct 24, 2025

View reviewed changes

drivers/adc/ltc2378/ltc2378.c Outdated Show resolved Hide resolved

drivers/adc/ltc2378/iio_ltc2378.c Show resolved Hide resolved

drivers/adc/ltc2378/iio_ltc2378.c Outdated Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from e1c00ca to 118b0d2 Compare October 28, 2025 04:03

jemfgeronimo reviewed Oct 28, 2025

View reviewed changes

drivers/adc/ltc2378/ltc2378.c Show resolved Hide resolved

projects/ltc2378/builds.json Outdated Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from 118b0d2 to 9f4765c Compare October 28, 2025 05:39

csarip marked this pull request as draft October 28, 2025 06:02

csarip force-pushed the dev/ltc2378-20 branch from 9f4765c to 67b68ba Compare October 28, 2025 08:53

jemfgeronimo self-requested a review October 28, 2025 09:08

jemfgeronimo reviewed Oct 29, 2025

View reviewed changes

drivers/adc/ltc2378/README.rst Outdated Show resolved Hide resolved

projects/ltc2378/README.rst Outdated Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from 67b68ba to 36f7683 Compare October 29, 2025 02:21

csarip marked this pull request as ready for review October 29, 2025 02:24

csarip force-pushed the dev/ltc2378-20 branch from 36f7683 to 850761a Compare October 29, 2025 02:41

jemfgeronimo mentioned this pull request Oct 29, 2025

Add support for MAX17616 #2734

Open

11 tasks

jemfgeronimo reviewed Oct 30, 2025

View reviewed changes

csarip marked this pull request as draft October 30, 2025 01:53

csarip force-pushed the dev/ltc2378-20 branch from 850761a to 71f0c5e Compare October 30, 2025 02:57

csarip marked this pull request as ready for review October 30, 2025 03:01

jemfgeronimo reviewed Nov 3, 2025

View reviewed changes

drivers/adc/ltc2378/README.rst Outdated Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from 71f0c5e to de506dc Compare November 12, 2025 07:17

csarip requested a review from amiclaus November 13, 2025 02:45

buha reviewed Nov 24, 2025

View reviewed changes

drivers/adc/ltc2378/ltc2378.c Outdated Show resolved Hide resolved

buha reviewed Nov 24, 2025

View reviewed changes

drivers/adc/ltc2378/iio_ltc2378.c Outdated Show resolved Hide resolved

buha reviewed Nov 24, 2025

View reviewed changes

projects/ltc2378/README.rst Outdated Show resolved Hide resolved

buha reviewed Nov 24, 2025

View reviewed changes

projects/ltc2378/src/examples/iio/iio_example.c Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from de506dc to 98a86d9 Compare February 2, 2026 07:55

csarip requested review from RaduSabau1, cristina-suteu, raezt, ralucabozdog, ranechita, rbudai98 and stefpopa as code owners February 2, 2026 07:55

amiclaus reviewed Feb 2, 2026

View reviewed changes

csarip force-pushed the dev/ltc2378-20 branch from 98a86d9 to 8143216 Compare February 2, 2026 10:36

amiclaus reviewed Feb 3, 2026

View reviewed changes

csarip added 5 commits February 4, 2026 13:52

drivers: adc: ltc2378: Add driver support for LTC2378

2a2f1b9

Add initial header and source files for LTC2378 driver. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

drivers: adc: ltc2378: Add IIO support for LTC2378

24f43f1

Add initial header and source file for LTC2378 IIO driver. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

drivers: adc: ltc2378: Add README documentation for LTC2378

e005111

Add README.rst documentation file for LTC2378 alongside other documentation related files. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

projects: ltc2378: Add project for LTC2378

deb3981

Add initial project files for both basic and IIO examples for LTC2378. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

projects: ltc2378: Add README documentation for project

a17da2d

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Cherrence Sarip <cherrence.sarip@analog.com>

csarip force-pushed the dev/ltc2378-20 branch from 8143216 to a17da2d Compare February 4, 2026 05:54

amiclaus reviewed Feb 4, 2026

View reviewed changes

Conversation

csarip commented Oct 22, 2025

Pull Request Description

Driver Features Implemented:

Project Examples Added:

PR Type

PR Checklist

Uh oh!

csarip commented Oct 23, 2025

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

csarip commented Oct 28, 2025

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

csarip commented Oct 29, 2025

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csarip commented Oct 30, 2025

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

csarip commented Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csarip commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csarip commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csarip commented Feb 4, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

amiclaus Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

amiclaus Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

amiclaus Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!