docs: use flex badges for status badges, img for logo#683
Merged
Conversation
Test Results1 712 tests ±0 461 ✅ ±0 11m 57s ⏱️ ±0s Results for commit 9b7b1c7. ± Comparison against base commit 8cce91e. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
tfcollins
requested changes
Sep 9, 2025
README.md
Outdated
| <a href="https://www.python.org/download/releases/3.8.0/"> | ||
| <img src="https://img.shields.io/badge/python-3.8+-blue.svg" alt="Python Version"> | ||
| <a href="https://www.python.org/downloads/"> | ||
| <img src="https://www.python.org/downloads/" alt="Python Version"> |
Collaborator
There was a problem hiding this comment.
This needs to reference an image
Contributor
Author
There was a problem hiding this comment.
Hi, sorry, copied the wrong link from the rst page
Collaborator
There was a problem hiding this comment.
Updated wrong one :) need to update the img tag not the link
b6152e0 to
b7fc006
Compare
tfcollins
requested changes
Sep 15, 2025
README.md
Outdated
| <a href="https://www.python.org/download/releases/3.8.0/"> | ||
| <img src="https://img.shields.io/badge/python-3.8+-blue.svg" alt="Python Version"> | ||
| <a href="https://www.python.org/downloads/"> | ||
| <img src="https://www.python.org/downloads/" alt="Python Version"> |
Collaborator
There was a problem hiding this comment.
Updated wrong one :) need to update the img tag not the link
Raw html doesn't work for other builder format. Since the logo image are written by a custom extension at the builder-inited step, prefix the image uri with ?:// to safely trick the builder into considering it as a remote uri, to not try to copy over and raise a warning. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
b7fc006 to
9b7b1c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raw html doesn't work for other builder formats.
Since the logo image are written by a custom extension at the
builder-inited step, prefix the image uri with ?:// to safely
trick the builder into considering it as a remote uri, to not
try to copy over and raise a warning.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: