fix(vite-plugin-angular): fix component HMR with angular 19.1.2 #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattlewis92
commented
Jan 21, 2025
| "nitropack": "^2.10.0", | ||
| "nx": "20.1.2", | ||
| "playwright": "^1.30.0", | ||
| "playwright": "^1.49.1", |
There was a problem hiding this comment.
Needed to fix the failing e2e tests which broke due to github recently upgrading github actions to use ubuntu 24. Support for ubuntu 24 was only added in playwright 1.45
Happy to make this a separate PR if needed
|
@mattlewis92 This line needs adjusting also |
Thanks! Fixed in |
brandonroberts
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
In angular
19.1.2component template urls were changed to be relative via angular/angular#59620. Unfortunately this breaks component template HMR with the vite pluginLuckily the fix is pretty straight forward (copied from angular/angular-cli#29386)
What is the new behavior?
Component template HMR works again
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?