Skip to content

fix(vite-plugin-angular): fix component HMR with angular 19.1.2 #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix(vite-plugin-angular): fix component HMR with angular 19.1.2 #1563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f601d57
fix(vite-plugin-angular): fix component HMR with angular 19.1.2
mattlewis92 Jan 20, 2025
08ccc05
build: upgrade playwright to fix failing e2e tests
mattlewis92 Jan 21, 2025
885fd7d
fix: add another place
mattlewis92 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
"ng-packagr": "^19.0.0",
"nitropack": "^2.10.0",
"nx": "20.1.2",
"playwright": "^1.30.0",
"playwright": "^1.49.1",
Copy link
Contributor Author

@mattlewis92 mattlewis92 Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to fix the failing e2e tests which broke due to github recently upgrading github actions to use ubuntu 24. Support for ubuntu 24 was only added in playwright 1.45

Happy to make this a separate PR if needed

"postcss": "^8.4.21",
"postcss-import": "~15.1.0",
"postcss-preset-env": "~8.0.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export function angular(options?: PluginOptions): Plugin[] {
return;
}

if (!req.url.startsWith(ANGULAR_COMPONENT_PREFIX)) {
if (!req.url.includes(ANGULAR_COMPONENT_PREFIX)) {
next();

return;
Expand Down Expand Up @@ -489,7 +489,7 @@ export function angular(options?: PluginOptions): Plugin[] {
if (
pluginOptions.liveReload &&
options?.ssr &&
id.startsWith(ANGULAR_COMPONENT_PREFIX)
id.includes(ANGULAR_COMPONENT_PREFIX)
) {
const requestUrl = new URL(id.slice(1), 'http://localhost');
const componentId = requestUrl.searchParams.get('c');
Expand Down
32 changes: 21 additions & 11 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading