Open
Conversation
Owner
|
Hi @akin2662, Thanks for the contribution, I wanted to raise few points...
pip install isort black flake8
# Run all checks
isort chromadesk
black chromadesk
flake8 --color auto --verbose --count --indent 4 --ignore=E501,F841,W503 --exclude .venv .
|
Owner
|
The Workflow is failing as well, to solve this you can take a fork of this repo and push the workflow on your fork and test your changes before pushing the change to this repo. Just a suggestion. Otherwise you can also use ACT. Take your time in raising the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is in reference to: ISSUE#13
I have written a workflow to audit pull requests. It uses flake8 to check the code and reviewdog for commenting. It also uses black and isort for checking the format of the code
Thank you!