Skip to content

PR audit workflow Issue# 13#19

Open
akin2662 wants to merge 2 commits intoanantdark:mainfrom
akin2662:pr_workflow
Open

PR audit workflow Issue# 13#19
akin2662 wants to merge 2 commits intoanantdark:mainfrom
akin2662:pr_workflow

Conversation

@akin2662
Copy link

@akin2662 akin2662 commented Apr 2, 2025

Hello,

This pull request is in reference to: ISSUE#13
I have written a workflow to audit pull requests. It uses flake8 to check the code and reviewdog for commenting. It also uses black and isort for checking the format of the code

Thank you!

@anantdark
Copy link
Owner

anantdark commented Apr 2, 2025

Hi @akin2662, Thanks for the contribution, I wanted to raise few points...

  1. In the flake8 check we need to ignore some rules(see below command) so would you recommend we add that to the workflow yml or create a config and read from that whenever we run flake8?
pip install isort black flake8

# Run all checks
isort chromadesk
black chromadesk
flake8 --color auto --verbose --count --indent 4 --ignore=E501,F841,W503 --exclude .venv .
  1. You have installed reviewdog but not called it, does it execute automatically on the PR?
  2. Will this only lint/check the code in PR or the whole project i.e. will it fail because of existing linting issues in code?

@anantdark anantdark self-assigned this Apr 2, 2025
@anantdark
Copy link
Owner

anantdark commented Apr 2, 2025

The Workflow is failing as well, to solve this you can take a fork of this repo and push the workflow on your fork and test your changes before pushing the change to this repo. Just a suggestion. Otherwise you can also use ACT. Take your time in raising the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants