Fix the long-full template for Read() to convert to Int64
#170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mithileshz
changed the title
long-full template for Read() to convert to Int64long-full template for Read() to convert to Int64
Author
|
I'm just going to add a unit test to this PR too so that we have a test covering this change for the future :) Edit: that's done now. |
andrewlock
reviewed
Mar 30, 2025
Owner
andrewlock
left a comment
andrewlock
left a comment
There was a problem hiding this comment.
Thanks for this! I think you'll also need to update one of the tests at least, though it's concerning that didn't obviously fail 🤔
| { | ||
| public override PLACEHOLDERID Read(ref global::System.Text.Json.Utf8JsonReader reader, global::System.Type typeToConvert, global::System.Text.Json.JsonSerializerOptions options) | ||
| => new (reader.GetInt32()); | ||
| => new (reader.GetInt64()); |
Owner
There was a problem hiding this comment.
I believe this change should cause a change in this snapshot? 🤔
Author
There was a problem hiding this comment.
Hey @andrewlock
I am unable to find the test that affects that snapshot. I had a look at the history of the snapshot here and wasn't able to find a test that is used for this specific snapshot. Can I get some help/a hint in where to look please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.