Skip to content

Fix the long-full template for Read() to convert to Int64 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the long-full template for Read() to convert to Int64 #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
023724e
Change the `long-full` template for Read() to convert to Int64
mithileshz Mar 22, 2025
ac0614e
Add unit test for maximum `long` value
mithileshz Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/StronglyTypedIds.Templates/long-full.typedid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
public partial class PLACEHOLDERIDSystemTextJsonConverter : global::System.Text.Json.Serialization.JsonConverter<PLACEHOLDERID>
{
public override PLACEHOLDERID Read(ref global::System.Text.Json.Utf8JsonReader reader, global::System.Type typeToConvert, global::System.Text.Json.JsonSerializerOptions options)
=> new (reader.GetInt32());
=> new (reader.GetInt64());
Copy link
Owner

@andrewlock andrewlock Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change should cause a change in this snapshot? 🤔

StronglyTypedId/test/StronglyTypedIds.Tests/Snapshots/UnknownTemplateCodeFixProviderUnitTests.UsesBuiltInTemplates_Long.verified.txt

Line 98 in 6bd17db

=> new (reader.GetInt32());

Copy link

@alikazai alikazai Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Author

@mithileshz mithileshz Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrewlock

I am unable to find the test that affects that snapshot. I had a look at the history of the snapshot here and wasn't able to find a test that is used for this specific snapshot. Can I get some help/a hint in where to look please?


public override void Write(global::System.Text.Json.Utf8JsonWriter writer, PLACEHOLDERID value, global::System.Text.Json.JsonSerializerOptions options)
=> writer.WriteNumberValue(value.Value);
Expand Down
12 changes: 12 additions & 0 deletions test/StronglyTypedIds.IntegrationTests/LongIdTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,18 @@ public void CanDeserializeFromLong_WithSystemTextJsonProvider()
Assert.Equal(foo, deserializedFoo);
}

[Fact]
public void CanDeserializeFromLong_MaxLongValue_WithSystemTextJsonProvider()
{
var value = long.MaxValue;
var foo = new ConvertersLongId(value);
var serializedLong = SystemTextJsonSerializer.Serialize(value);

var deserializedFoo = SystemTextJsonSerializer.Deserialize<ConvertersLongId>(serializedLong);

Assert.Equal(foo, deserializedFoo);
}

[Fact]
public void WhenEfCoreValueConverterUsesValueConverter()
{
Expand Down