Skip to content

add pre-commit configuration file#59

Merged
andrewtavis merged 11 commits intoandrewtavis:mainfrom
sayik:pre-commit-config
Dec 19, 2025
Merged

add pre-commit configuration file#59
andrewtavis merged 11 commits intoandrewtavis:mainfrom
sayik:pre-commit-config

Conversation

@sayik
Copy link
Collaborator

@sayik sayik commented Dec 6, 2025

Added pre-commit configuration file.

fixes #57

@@ -1,3 +1,5 @@
# SPDX-License-Identifier: BSD-3-Clause

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the space between the license identifier and the next line, @sayik :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will fix

Copy link
Owner

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a call with @sayik now to check this :) We're agreeing that this is a good state to merge so that the new dependencies will be added as well as the environment setup directions. Plan from here is fixes for pr_ci, and we'll then focus on python_package_ci after that 😊

praise: Thanks so much for the great work here, @sayik! Looking forward to working on this with you :)

@andrewtavis andrewtavis merged commit 2af0516 into andrewtavis:main Dec 19, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pre-commit configuration file.

2 participants