Avoid potentially exception throwing side effects from IdlingResourceTimeoutException being thrown
#2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
piper_800164506
branch
3 times, most recently
from
419aaff to
ab6d9d7
Compare
…eTimeoutException` being thrown Interactions with `TestOutputEmitter` can throw, and if it does it suppresses the `IdlingResourceTimeoutException` exception from even being created. Instead of having this side effect in the `IdlingResourceTimeoutException` constructor move the thread dumping out of the constructor and wrap it in a try/catch, attaching any exceptions as suppressed by the `IdlingResourceTimeoutException` exception. In particular this can happen if more than one `TestOutputHandler` is registered. PiperOrigin-RevId: 802381773
copybara-service
bot
force-pushed
the
piper_800164506
branch
from
ab6d9d7 to
d257dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid potentially exception throwing side effects from
IdlingResourceTimeoutExceptionbeing thrownInteractions with
TestOutputEmittercan throw, and if it does it suppresses theIdlingResourceTimeoutExceptionexception from even being created. Instead of having this side effect in theIdlingResourceTimeoutExceptionconstructor move the thread dumping out of the constructor and wrap it in a try/catch, attaching any exceptions as suppressed by theIdlingResourceTimeoutExceptionexception.In particular this can happen if more than one
TestOutputHandleris registered.