[JetLagged] Fix drawer animation logic

[cartland]

The drawer animation logic had a bug where it would not properly animate the drawer to the correct position.

This commit fixes the issue by adjusting the conditions that determine whether the drawer can reach the target position with decay. Specifically, it checks if actualTargetX > 0f instead of targetDifference > 0f and actualTargetX == 0f instead of targetDifference < 0f.

[gemini-code-assist]

Summary of Changes

Hello @cartland, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the drawer animation system, ensuring that the drawer consistently animates to its intended position. The changes refine the underlying mathematical conditions that govern the animation's decay behavior, leading to a more robust and visually correct UI component.

Highlights

• Drawer Animation Logic Fix: I've addressed a bug in the drawer animation logic that prevented the drawer from animating correctly to its target position. This ensures a smoother and more predictable user experience when interacting with the drawer.
• Refined Decay Animation Conditions: The core of the fix involves adjusting the conditions within the canReachTargetWithDecay logic. I've replaced checks based on targetDifference with direct checks on actualTargetX (specifically actualTargetX > 0f and actualTargetX == 0f) to more accurately determine if the drawer can reach its target with decay.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug in the drawer animation logic. The review includes a suggestion to refactor the conditional logic to improve its readability and make the intent clearer for future maintenance.

[gemini-code-assist]

The compound condition for canReachTargetWithDecay is dense and can be hard to understand at a glance. The use of actualTargetX > 0f to imply that the drawer is opening is not immediately obvious.

To improve readability and maintainability, refactor this logic to be more explicit about its intent. An if/else structure based on the target state (opening vs. closing) would make the conditions for checking if the fling will overshoot the target much clearer.

                            val canReachTargetWithDecay = if (actualTargetX > 0f) {
                                // We are aiming for the open state, check if the fling is strong
                                // enough to overshoot.
                                velocity > 0f && targetOffsetX > actualTargetX
                            } else {
                                // We are aiming for the closed state, check if the fling is strong
                                // enough to overshoot.
                                velocity < 0f && targetOffsetX < actualTargetX
                            }