Skip to content

Conversation

@Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented May 3, 2024

What I have done and why

Using Gradle DependencyHandler add method rather than plain text in dependencies block.

How I'm testing it

Choose at least one:

  • Unit tests
  • UI tests
  • Screenshot tests
  • N/A (provide justification)

Change-Id: I128b974d43780f70db9fb3a6357d11c0ebc1ddaa
@keyboardsurfer
Copy link
Member

Thanks for your PR. Currently there are conflicts that need to be resolved before we can move on to possibly accepting your contribution. Please resolve the conflicts.

Change-Id: I10f8dddf0153555823a0a2b09c259d3914db9937

# Conflicts:
#	build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt
#	build-logic/convention/src/main/kotlin/AndroidHiltConventionPlugin.kt
Change-Id: I33860d84cf111173d8e8f284bd4f3ce0336a4871
Change-Id: I2b8c2959b825c44e9cea90a24adbb134b84a420e
@Jaehwa-Noh
Copy link
Contributor Author

Superseded by #1739

@Jaehwa-Noh Jaehwa-Noh closed this Dec 14, 2024
@Jaehwa-Noh Jaehwa-Noh deleted the gradle-method branch December 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants