Skip to content

Change plain text to add method. #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jaehwa-Noh wants to merge 4 commits into from
Closed

Change plain text to add method. #1412

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02c47a2
Change plain text to `add` method.
Jaehwa-Noh May 3, 2024
b8872bf
Merge branch 'android-remote-main' into gradle-method
Jaehwa-Noh Dec 14, 2024
8f001c3
Set exclude.
Jaehwa-Noh Dec 14, 2024
ec501f7
Replace to proper `notations`.
Jaehwa-Noh Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,23 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
apply("com.google.firebase.crashlytics")
}

configurations.forEach {
/*
Exclusion of protobuf / protolite dependencies is necessary as the
datastore-proto brings in protobuf dependencies. These are the source of truth
for Now in Android.
That's why the duplicate classes from below dependencies are excluded.
*/
it.exclude(group = "com.google.protobuf", module = "protobuf-javalite")
it.exclude(group = "com.google.firebase", module = "protolite-well-known-types")
}

dependencies {
val bom = libs.findLibrary("firebase-bom").get()
add("implementation", platform(bom))
"implementation"(libs.findLibrary("firebase.analytics").get())
"implementation"(libs.findLibrary("firebase.performance").get()) {
/*
Exclusion of protobuf / protolite dependencies is necessary as the
datastore-proto brings in protobuf dependencies. These are the source of truth
for Now in Android.
That's why the duplicate classes from below dependencies are excluded.
*/
exclude(group = "com.google.protobuf", module = "protobuf-javalite")
exclude(group = "com.google.firebase", module = "protolite-well-known-types")
}
"implementation"(libs.findLibrary("firebase.crashlytics").get())
add("implementation", libs.findLibrary("firebase.analytics").get())
add("implementation", libs.findLibrary("firebase.performance").get())
add("implementation", libs.findLibrary("firebase.crashlytics").get())
}

extensions.configure<ApplicationExtension> {
Expand Down