Followed Kotlin DSL without type-safe accessors documentation #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8fa1a79ea71578395a4ce861ff883f8f6f01cdd0
https://docs.gradle.org/current/userguide/kotlin_dsl.html#ex-configuring-plugins-without-type-safe-accessors Change-Id: Id711ad25146e291cbae40a5df4251f0ffef7b0a6
dturner
requested changes
Dec 17, 2024
Collaborator
There was a problem hiding this comment.
I'm more in favour of this format:
"implementation"(libs.findLibrary("hilt.core").get())
Why?
- It follows the exact format recommended by https://docs.gradle.org/current/userguide/kotlin_dsl.html#ex-configuring-plugins-without-type-safe-accessors
- It's more obvious to newcomers how to add dependencies for a new source set (e.g.
androidTestImplementation) without needing to updateStringSources.kt - I agree the strings add type safety, but they are at the expense of another level of abstraction which I feel isn't worth the tradeoff
Contributor
Author
|
@dturner Okay, I will accept your suggestion. Removing the string file and replacing it with a plain String. |
Change-Id: I17972f94277364cd588f40d422370b21e40af0e9
Change-Id: I3f4ead0be88ed460de007dae7b53c4d2f6c2249b
Contributor
Author
|
@dturner I've restored to the plain string text. Kindly check it. |
dturner
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
Followed Kotlin DSL without type-safe accessors documentation, and reduced likely occurs typo error by replacing string to a const variable.
https://docs.gradle.org/current/userguide/kotlin_dsl.html#ex-configuring-plugins-without-type-safe-accessors