-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Change ViewModel visibility from public to internal for all feature modules #1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate it if you could take a look at this PR when you get the chance
Made some visibility changes to ViewModels for better encapsulation between modules.
Happy to make any changes if needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dturner please take a look at this PR when you have time
What I have done and why
Changed the visibility modifier of all ViewModel classes within their respective feature modules from public to internal, ensuring that ViewModels are only accessible within their own modules.
This modification improves encapsulation and enforces clear module boundaries, preventing unintended usage of ViewModels across modules.
By restricting access with the internal modifier, the codebase becomes more maintainable and less prone to unintended dependencies.
Updated each feature module separately to reflect this visibility change, keeping each commit modular and easier to review.
Updated Modules
The following feature modules have been updated: