Skip to content

Change ViewModel visibility from public to internal for all feature modules #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Change ViewModel visibility from public to internal for all feature modules #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3a1ce05
Refactor BookmarksViewModel ViewModels to internal modifier
audgns10 Aug 2, 2025
e3c53be
Refactor ForYouViewModel ViewModels to internal modifier
audgns10 Aug 2, 2025
a775e75
Refactor InterestsViewModel ViewModels to internal modifier
audgns10 Aug 2, 2025
9347bd7
Refactor SearchViewModel ViewModels to internal modifier
audgns10 Aug 2, 2025
76b4a55
Refactor SettingViewModel ViewModels to internal modifier
audgns10 Aug 2, 2025
433aa78
Refactor TopicViewModel ViewModels to internal modifier
audgns10 Aug 2, 2025
5a3240b
Revert InterestsViewModel modifiers to public
audgns10 Aug 2, 2025
b69273e
Revert SettingsViewModel modifiers to public
audgns10 Aug 2, 2025
8c6ff5f
Revert TopicViewModel modifiers to public
audgns10 Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import kotlinx.coroutines.launch
import javax.inject.Inject

@HiltViewModel
class BookmarksViewModel @Inject constructor(
internal class BookmarksViewModel @Inject constructor(
private val userDataRepository: UserDataRepository,
userNewsResourceRepository: UserNewsResourceRepository,
) : ViewModel() {
Expand Down
2 changes: 1 addition & 1 deletion ...ou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/ForYouViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import kotlinx.coroutines.launch
import javax.inject.Inject

@HiltViewModel
class ForYouViewModel @Inject constructor(
internal class ForYouViewModel @Inject constructor(
private val savedStateHandle: SavedStateHandle,
syncManager: SyncManager,
private val analyticsHelper: AnalyticsHelper,
Expand Down
2 changes: 1 addition & 1 deletion ...ch/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import kotlinx.coroutines.launch
import javax.inject.Inject

@HiltViewModel
class SearchViewModel @Inject constructor(
internal class SearchViewModel @Inject constructor(
getSearchContentsUseCase: GetSearchContentsUseCase,
recentSearchQueriesUseCase: GetRecentSearchQueriesUseCase,
private val searchContentsRepository: SearchContentsRepository,
Expand Down