feat(mf-tools): enhance connectRouter to support baseHref for URL navigation #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates module federation tools, the micro frontend router integration to improve support for custom base hrefs in Angular applications. The main changes ensure that the router correctly handles navigation when a base href is set, which is important for apps deployed under sub-paths.
Routing improvements:
APP_BASE_HREFfrom the Angular injector and passed it to the router connection logic inbootstrap-utils.ts, enabling dynamic base href support. [1] [2]connectRouterfunction inrouter-utils.tsto accept abaseHrefparameter and remove the base href from the beginning of navigation URL if present, ensuring correct routing behavior for apps with a non-root base path.