Skip to content

feat(mf-tools): enhance connectRouter to support baseHref for URL navigation #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(mf-tools): enhance connectRouter to support baseHref for URL navigation #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libs/mf-tools/src/lib/web-components/bootstrap-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import {
PlatformRef,
Type,
Version,
VERSION,
} from '@angular/core';
import { platformBrowser } from '@angular/platform-browser';
import { VERSION } from '@angular/core';
import { APP_BASE_HREF } from '@angular/common';
import {
getGlobalStateSlice,
setGlobalStateSlice,
Expand Down Expand Up @@ -211,12 +212,13 @@ function shareShellZone(injector: Injector) {

function connectMicroFrontendRouter(injector: Injector) {
const router = injector.get(Router);
const baseHref = injector.get(APP_BASE_HREF, '');
const useHash = location.href.includes('#');

if (!router) {
console.warn('No router to connect found');
return;
}

connectRouter(router, useHash);
connectRouter(router, useHash, baseHref);
}
9 changes: 8 additions & 1 deletion libs/mf-tools/src/lib/web-components/router-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,17 @@ export function endsWith(prefix: string): UrlMatcher {
};
}

export function connectRouter(router: Router, useHash = false): void {
export function connectRouter(
router: Router,
useHash = false,
baseHref?: string
): void {
let url: string;
if (!useHash) {
url = `${location.pathname.substring(1)}${location.search}`;
if (baseHref && url.startsWith(baseHref)) {
url = url.replace(baseHref, '');
}
router.navigateByUrl(url);
window.addEventListener('popstate', () => {
router.navigateByUrl(url);
Expand Down