Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 4, 2024

This commit revises the app-shell and server schematics to incorporate the new Server Rendering API, along with the integration of server-side routes.

BREAKING CHANGE: The app-shell schematic is no longer compatible with Webpack-based builders.

@alan-agius4 alan-agius4 marked this pull request as draft October 4, 2024 08:05
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 4, 2024
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit area: @schematics/angular labels Oct 4, 2024
@alan-agius4 alan-agius4 changed the title feat(@schematics/angular): update app-shell and server schematics to adopt new Server Rendering API feat(@schematics/angular): update app-shell and ssr schematics to adopt new Server Rendering API Oct 4, 2024
@alan-agius4 alan-agius4 force-pushed the ssr-new-api-schematic-integration branch 7 times, most recently from 32f3ff5 to 6aabfc0 Compare October 4, 2024 10:14
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 4, 2024
@alan-agius4 alan-agius4 requested review from clydin and dgp1130 October 4, 2024 10:16
@alan-agius4 alan-agius4 marked this pull request as ready for review October 4, 2024 10:20
@alan-agius4 alan-agius4 force-pushed the ssr-new-api-schematic-integration branch from 6aabfc0 to 34d2ba2 Compare October 8, 2024 09:14
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not super familiar with schematics. Maybe @clydin has more useful feedback to give here?

@alan-agius4 alan-agius4 force-pushed the ssr-new-api-schematic-integration branch from 34d2ba2 to 2c34351 Compare October 9, 2024 07:13
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 9, 2024
@alan-agius4 alan-agius4 force-pushed the ssr-new-api-schematic-integration branch 4 times, most recently from 6f15747 to e30b9a6 Compare October 9, 2024 10:07
@alan-agius4 alan-agius4 force-pushed the ssr-new-api-schematic-integration branch from e30b9a6 to 91b9704 Compare October 9, 2024 10:11
@alan-agius4 alan-agius4 force-pushed the ssr-new-api-schematic-integration branch 4 times, most recently from 179b846 to 8d6a561 Compare October 9, 2024 11:14
…pt new Server Rendering API

This commit revises the app-shell and ssr schematics to incorporate the new Server Rendering API, along with the integration of server-side routes.

BREAKING CHANGE: The app-shell schematic is no longer compatible with Webpack-based builders.
@alan-agius4 alan-agius4 force-pushed the ssr-new-api-schematic-integration branch from 8d6a561 to 5e8aeec Compare October 9, 2024 11:26
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2024
@alan-agius4 alan-agius4 merged commit 292a4b7 into angular:main Oct 9, 2024
30 checks passed
@alan-agius4 alan-agius4 deleted the ssr-new-api-schematic-integration branch October 9, 2024 16:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants