Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 17, 2024

Note: While we should remove standalone: true, this is currently not feasible due to angular/angular#58241.

@alan-agius4 alan-agius4 marked this pull request as draft October 17, 2024 08:16
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 17, 2024
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 17, 2024
@alan-agius4 alan-agius4 force-pushed the pr-takeover-28652 branch 3 times, most recently from fccbea6 to c8f1247 Compare October 17, 2024 09:22
In tests, add `standalone: false` where it's missing.

Note: In the future, we should update our integration tests to use a standalone app.
@alan-agius4 alan-agius4 marked this pull request as ready for review October 17, 2024 10:07
@alan-agius4 alan-agius4 requested a review from clydin October 17, 2024 10:07
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2024
@jkrems jkrems merged commit 3cbbf45 into angular:main Oct 17, 2024
43 checks passed
@alan-agius4 alan-agius4 deleted the pr-takeover-28652 branch October 17, 2024 14:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants