Skip to content

build: update angular #28654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024
Merged

build: update angular #28654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f8252
build: update angular
angular-robot Oct 17, 2024
4919fdf
refactor: handle standalone by default change
alan-agius4 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/testing/builder/projects/hello-world-app/src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { Component } from '@angular/core';

@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.html',
styleUrls: ['./app.component.css'],
})
Expand Down
24 changes: 12 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,23 @@
},
"devDependencies": {
"@ampproject/remapping": "2.3.0",
"@angular/animations": "19.0.0-next.9",
"@angular/animations": "19.0.0-next.10",
"@angular/bazel": "patch:@angular/bazel@https%3A//github.com/angular/bazel-builds.git%23commit=07617f0f8540d27f8895b1820a6f994e1e5b7277#~/.yarn/patches/@angular-bazel-https-9848736cf4.patch",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#2692c81ef1068e15c7b7eaf3ecc7a65cbdd25c9f",
"@angular/cdk": "19.0.0-next.8",
"@angular/common": "19.0.0-next.9",
"@angular/compiler": "19.0.0-next.9",
"@angular/compiler-cli": "19.0.0-next.9",
"@angular/core": "19.0.0-next.9",
"@angular/forms": "19.0.0-next.9",
"@angular/localize": "19.0.0-next.9",
"@angular/common": "19.0.0-next.10",
"@angular/compiler": "19.0.0-next.10",
"@angular/compiler-cli": "19.0.0-next.10",
"@angular/core": "19.0.0-next.10",
"@angular/forms": "19.0.0-next.10",
"@angular/localize": "19.0.0-next.10",
"@angular/material": "19.0.0-next.8",
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#2659cef857ffd127dbbbcbb28bb2dc4ca8625b50",
"@angular/platform-browser": "19.0.0-next.9",
"@angular/platform-browser-dynamic": "19.0.0-next.9",
"@angular/platform-server": "19.0.0-next.9",
"@angular/router": "19.0.0-next.9",
"@angular/service-worker": "19.0.0-next.9",
"@angular/platform-browser": "19.0.0-next.10",
"@angular/platform-browser-dynamic": "19.0.0-next.10",
"@angular/platform-server": "19.0.0-next.10",
"@angular/router": "19.0.0-next.10",
"@angular/service-worker": "19.0.0-next.10",
"@babel/core": "7.25.8",
"@babel/generator": "7.25.7",
"@babel/helper-annotate-as-pure": "7.25.7",
Expand Down
5 changes: 3 additions & 2 deletions packages/angular/build/src/builders/application/tests/behavior/rebuild-errors_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {

const goodDirectiveContents = `
import { Directive, Input } from '@angular/core';
@Directive({ selector: 'dir' })
@Directive({ selector: 'dir', standalone: false })
export class Dir {
@Input() foo: number;
}
Expand Down Expand Up @@ -66,6 +66,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
import { Component } from '@angular/core'
@Component({
selector: 'app-root',
standalone: false,
template: '<dir [foo]="123">',
})
export class AppComponent { }
Expand All @@ -87,7 +88,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
'src/app/dir.ts',
`
import { Directive, Input } from '@angular/core';
@Directive({ selector: 'dir' })
@Directive({ selector: 'dir', standalone: false })
export class Dir {
@Input() foo: string;
}
Expand Down
1 change: 1 addition & 0 deletions packages/angular/build/src/builders/application/tests/behavior/rebuild-general_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
import './file-a';
@Component({
selector: 'app-root',
standalone: false,
template: 'App component',
})
export class AppComponent { }
Expand Down
1 change: 1 addition & 0 deletions packages/angular/build/src/builders/application/tests/behavior/rebuild-web-workers_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
import { Component } from '@angular/core'
@Component({
selector: 'app-root',
standalone: false,
template: '<h1>Worker Test</h1>',
})
export class AppComponent {
Expand Down
1 change: 1 addition & 0 deletions ...ges/angular/build/src/builders/application/tests/behavior/web-workers-application_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
import { Component } from '@angular/core'
@Component({
selector: 'app-root',
standalone: false,
template: '<h1>Worker Test</h1>',
})
export class AppComponent {
Expand Down
1 change: 1 addition & 0 deletions packages/angular/build/src/builders/application/tests/options/app-shell_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const appShellRouteFiles: Record<string, string> = {
@Component({
selector: 'app-app-shell',
standalone: false,
styles: ['div { color: #fff; }'],
template: '<p>app-shell works!</p>',
})
Expand Down
1 change: 1 addition & 0 deletions packages/angular/build/src/builders/application/tests/options/external-dependencies_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
import { Component } from '@angular/core'
@Component({
selector: 'app-root',
standalone: false,
template: '<h1>Worker Test</h1>',
})
export class AppComponent {
Expand Down
12 changes: 6 additions & 6 deletions packages/angular/ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
"@angular/router": "^19.0.0-next.0"
},
"devDependencies": {
"@angular/common": "19.0.0-next.9",
"@angular/compiler": "19.0.0-next.9",
"@angular/core": "19.0.0-next.9",
"@angular/platform-browser": "19.0.0-next.9",
"@angular/platform-server": "19.0.0-next.9",
"@angular/router": "19.0.0-next.9",
"@angular/common": "19.0.0-next.10",
"@angular/compiler": "19.0.0-next.10",
"@angular/core": "19.0.0-next.10",
"@angular/platform-browser": "19.0.0-next.10",
"@angular/platform-server": "19.0.0-next.10",
"@angular/router": "19.0.0-next.10",
"@bazel/runfiles": "^5.8.1"
},
"schematics": "./schematics/collection.json",
Expand Down
1 change: 1 addition & 0 deletions packages/angular_devkit/build_angular/src/builders/app-shell/app-shell_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ describe('AppShell Builder', () => {
@Component({
selector: 'app-app-shell',
standalone: false,
templateUrl: './app-shell.component.html',
})
export class AppShellComponent implements OnInit {
Expand Down
4 changes: 4 additions & 0 deletions packages/angular_devkit/build_angular/src/builders/browser/specs/styles_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ describe('Browser Builder styles', () => {
@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.html',
styleUrls: []
})
Expand All @@ -92,6 +93,7 @@ describe('Browser Builder styles', () => {
@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.html',
styles: ['div { mask-composite: add; }'],
})
Expand All @@ -118,6 +120,7 @@ describe('Browser Builder styles', () => {
@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.html',
styles: ['div { mask-composite: add; }'],
})
Expand Down Expand Up @@ -637,6 +640,7 @@ describe('Browser Builder styles', () => {
@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.html',
styleUrls: ['../styles.css']
})
Expand Down
1 change: 1 addition & 0 deletions packages/angular_devkit/build_angular/src/builders/browser/specs/svg_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ describe('Browser Builder allow svg', () => {
@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.svg',
styleUrls: []
})
Expand Down
12 changes: 7 additions & 5 deletions ...s/angular_devkit/build_angular/src/builders/browser/tests/behavior/rebuild-errors_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {

const goodDirectiveContents = `
import { Directive, Input } from '@angular/core';
@Directive({ selector: 'dir' })
@Directive({ selector: 'dir', standalone: false })
export class Dir {
@Input() foo: number;
}
Expand Down Expand Up @@ -61,6 +61,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
import { Component } from '@angular/core'
@Component({
selector: 'app-root',
standalone: false,
template: '<dir [foo]="123">',
})
export class AppComponent { }
Expand All @@ -82,7 +83,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
'src/app/dir.ts',
`
import { Directive, Input } from '@angular/core';
@Directive({ selector: 'dir' })
@Directive({ selector: 'dir', standalone: false })
export class Dir {
@Input() foo: string;
}
Expand Down Expand Up @@ -162,7 +163,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
'src/app/dir.ts',
`
import { Directive, Input } from '@angular/core';
@Directive({ selector: 'dir' })
@Directive({ selector: 'dir', standalone: false })
export class Dir {
@Input() foo: number;
}
Expand All @@ -172,7 +173,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
// Same selector with a different type on the `foo` property but initially no `@Input`
const goodDirectiveContents = `
import { Directive } from '@angular/core';
@Directive({ selector: 'dir' })
@Directive({ selector: 'dir', standalone: false })
export class Dir2 {
foo: string;
}
Expand Down Expand Up @@ -210,6 +211,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
import { Component } from '@angular/core'
@Component({
selector: 'app-root',
standalone: false,
template: '<dir [foo]="123">',
})
export class AppComponent { }
Expand All @@ -231,7 +233,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
'src/app/dir2.ts',
`
import { Directive, Input } from '@angular/core';
@Directive({ selector: 'dir' })
@Directive({ selector: 'dir', standalone: false })
export class Dir2 {
@Input() foo: string;
}
Expand Down
1 change: 1 addition & 0 deletions packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/fake-async_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
@Component({
selector: 'app-root',
standalone: false,
template: '<button (click)="changeMessage()" class="change">{{ message }}</button>',
})
export class AppComponent {
Expand Down
1 change: 1 addition & 0 deletions packages/angular_devkit/build_angular/src/builders/karma/tests/options/assets_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
@Component({
selector: 'app-root',
standalone: false,
template: '<p *ngFor="let asset of assets">{{ asset.content }}</p>'
})
export class AppComponent {
Expand Down
1 change: 1 addition & 0 deletions packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.html',
styleUrls: ['./app.component.css']
})
Expand Down
2 changes: 2 additions & 0 deletions packages/angular_devkit/build_angular/src/builders/karma/tests/options/styles_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
@Component({
selector: 'app-root',
standalone: false,
template: '<p>Hello World</p>'
})
export class AppComponent {
Expand Down Expand Up @@ -79,6 +80,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
import { HttpClient } from '@angular/common/http';
@Component({
selector: 'app-root',
standalone: false,
template: '<p *ngFor="let asset of css">{{ asset.content }}</p>'
})
export class AppComponent {
Expand Down
1 change: 1 addition & 0 deletions ...angular_devkit/build_angular/src/builders/karma/tests/options/web-worker-tsconfig_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget, isAppli
@Component({
selector: 'app-root',
standalone: false,
template: ''
})
export class AppComponent {
Expand Down
1 change: 1 addition & 0 deletions packages/angular_devkit/build_angular/src/builders/prerender/works_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ describe('Prerender Builder', () => {
@Component({
selector: 'app-foo',
standalone: false,
template: '<p>foo works!</p>',
})
export class FooComponent {}
Expand Down
19 changes: 0 additions & 19 deletions ...ages/angular_devkit/build_angular/test/hello-world-lib/projects/lib/src/lib/lib.module.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/angular_devkit/build_angular/test/hello-world-lib/projects/lib/src/public-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@

export * from './lib/lib.service';
export * from './lib/lib.component';
export * from './lib/lib.module';
1 change: 1 addition & 0 deletions packages/angular_devkit/build_webpack/test/angular-app/src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { Component } from '@angular/core';

@Component({
selector: 'app-root',
standalone: false,
templateUrl: './app.component.html',
styleUrls: ['./app.component.css'],
})
Expand Down
4 changes: 2 additions & 2 deletions packages/ngtools/webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
},
"devDependencies": {
"@angular-devkit/core": "0.0.0-PLACEHOLDER",
"@angular/compiler": "19.0.0-next.9",
"@angular/compiler-cli": "19.0.0-next.9",
"@angular/compiler": "19.0.0-next.10",
"@angular/compiler-cli": "19.0.0-next.10",
"typescript": "5.6.3",
"webpack": "5.95.0"
}
Expand Down
26 changes: 13 additions & 13 deletions tests/legacy-cli/e2e/ng-snapshot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@
"description": "snapshot versions of Angular for e2e testing",
"private": true,
"dependencies": {
"@angular/animations": "github:angular/animations-builds#a6515a9123c48cd4d9ee31daa69ded6b8b357872",
"@angular/animations": "github:angular/animations-builds#ef3ce5e787d5f870c0f7c21510706400fa11722e",
"@angular/cdk": "github:angular/cdk-builds#376404c773bc651f313e7d5e0f42dd6fabfb55db",
"@angular/common": "github:angular/common-builds#faf058aea686cb610b9c75cd98aba047154533c4",
"@angular/compiler": "github:angular/compiler-builds#395e6976d7b1c04978ed31f3170a336722ffd09d",
"@angular/compiler-cli": "github:angular/compiler-cli-builds#0259f5b926a6ce5dd876647d4efbc8f3ffea161c",
"@angular/core": "github:angular/core-builds#74c060d5d256a166378c2f90a56ed3d17d7fee59",
"@angular/forms": "github:angular/forms-builds#12f75f8344cd94bdcefff7daee7a97c73a06c0ba",
"@angular/language-service": "github:angular/language-service-builds#8c45bf63422029cdaa203183860d4186cdd57d94",
"@angular/localize": "github:angular/localize-builds#b156942dac5030f1fa39f4230cec96de895f9b9f",
"@angular/common": "github:angular/common-builds#049304f01a5bc5e758539932769598d13c72ab4c",
"@angular/compiler": "github:angular/compiler-builds#c487461b6699cba896b46bef755c0b0d5452ba8e",
"@angular/compiler-cli": "github:angular/compiler-cli-builds#e47428be5964227c77a133e1d8f5ab791cba9d20",
"@angular/core": "github:angular/core-builds#dab315712fdf6edcf7a1e15a8b04180df014de7b",
"@angular/forms": "github:angular/forms-builds#2e42a6e88be33a5931aee21bf53d0a08a70ab04f",
"@angular/language-service": "github:angular/language-service-builds#2d1d429c1a5d043966ad12dadb06c1e6c02dce90",
"@angular/localize": "github:angular/localize-builds#ef01885e209ca3e94e450695af8f42623fb92718",
"@angular/material": "github:angular/material-builds#051bc235964598b6a616a52510217c9e5fea9c46",
"@angular/material-moment-adapter": "github:angular/material-moment-adapter-builds#d6c95738690917961d6c0d3ff1759ca707b696bf",
"@angular/platform-browser": "github:angular/platform-browser-builds#691e91fffa748582a74896e98b65de4d30f01116",
"@angular/platform-browser-dynamic": "github:angular/platform-browser-dynamic-builds#e7ec7c4ecfcc1be1d88090d5743e93085641acfe",
"@angular/platform-server": "github:angular/platform-server-builds#63dcbb67c5582b8ed2d347b3168acf643658d834",
"@angular/router": "github:angular/router-builds#5d188935296281cc596afc3d50c1d0d73c0dd5bd",
"@angular/service-worker": "github:angular/service-worker-builds#4baac08899ac332404262b8252de24950e89498a"
"@angular/platform-browser": "github:angular/platform-browser-builds#cd5b7869733a23f948158c8490f1a52807c14023",
"@angular/platform-browser-dynamic": "github:angular/platform-browser-dynamic-builds#5978ab37e4047188628783eba84ebca1596ce9d1",
"@angular/platform-server": "github:angular/platform-server-builds#17444a8ea00f2c0d67783056590ef77f54ffcae7",
"@angular/router": "github:angular/router-builds#17d028eade1086859bbb05e7f9c9f79db4faabff",
"@angular/service-worker": "github:angular/service-worker-builds#a585fa97bfcdbdc0bbf6d088ccdd1610eb2aa35c"
}
}
Loading