Skip to content

Conversation

alan-agius4
Copy link
Collaborator

This commit tries to display pnpm-lock.yaml update using renovate and instead it uses yarn bazel run @npm2//:sync.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 16, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed area: build & ci Related the build and CI infrastructure of the project labels Dec 16, 2024
renovate.json Outdated
"tests/legacy-cli/e2e/ng-snapshot/package.json",
".github/workflows/**/*.yml"
],
"ignorePaths": ["pnpm-lock.yaml"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be done instead with adding this into the package rules?

{
  "matchPackageManagers": ["pnpm"],
  "enabled": false
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, should be matchManagers

{
  "matchManagers": ["pnpm"],
  "enabled": false
},

This commit tries to display `pnpm-lock.yaml` update using renovate and instead it uses `yarn bazel run @npm2//:sync`.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 16, 2024
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 merged commit 2f51b66 into angular:main Dec 16, 2024
31 checks passed
@alan-agius4 alan-agius4 deleted the pnpm-lock-update branch December 16, 2024 18:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants