build: fix strict_deps for angular-cli test lib #29674
Conversation
josephperrott
added
action: review
| ignore_strict_deps = True, | ||
| deps = [ | ||
| ":angular-cli_rjs", | ||
| ":node_modules/@angular-devkit/core", |
There was a problem hiding this comment.
Would we prefer to move from the ts_project dependency here to the npm package one?
Or should the clean up be to migrate to relative paths? If I understand/remember correctly, we want to use the npm package here so that we don't cross the npm package boundary with relative paths.
If there were imports from @angular/cli those should be relative import paths instead though.
There was a problem hiding this comment.
This makes a lot of sense. It's just a leftover because apparently no runtime test broke (likely due to the transitive deps!!). My goal is to restrict/fix this and make it safe by leveraging Bazel visibility rules better
| ignore_strict_deps = True, | ||
| deps = [ | ||
| ":angular-cli_rjs", | ||
| ":node_modules/@angular-devkit/core", |
There was a problem hiding this comment.
This makes a lot of sense. It's just a leftover because apparently no runtime test broke (likely due to the transitive deps!!). My goal is to restrict/fix this and make it safe by leveraging Bazel visibility rules better
josephperrott
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
No description provided.